unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: bruce.connor.am@gmail.com
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 29c360e: Ensure redisplay after "C-x C-e"
Date: Fri, 06 Nov 2015 17:30:56 +0200	[thread overview]
Message-ID: <83si4jqh5b.fsf@gnu.org> (raw)
In-Reply-To: <CAAdUY-Kc+V2fuNHksBQ8Pf57YGMqphBwepD1HXbc0t3Zoy7fWw@mail.gmail.com>

> Date: Fri, 6 Nov 2015 14:53:01 +0000
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel <emacs-devel@gnu.org>
> 
> > "C-x C-e"
> 
> C-x C-e is not the only way to evaluate arbitrary lisp code, there are
> plenty of others (eval-buffer, eval-region, eval-defun,
> eval-expression, etc).

Does any of them cause the problem I tried to fix?  IOW, if any of
these include the form (setq line-spacing 1.0), does evaluating it
fail to redraw the selected window with the new line-spacing?

> Sounds odd to single out eval-last-sexp here.

I singled it out because it was the only situation I saw where the
evaluation had no effect.

> Wouldn't it be better to redisplay more aggressively? Maybe ensure
> that the calling the `eval` function always causes a redisplay after
> the command-loop?

The problem here was not to call redisplay -- it is always entered
after Emacs finishes running the last command, in this case "C-x C-e".
The problem was to tell redisplay it should consider redrawing the
selected window even though no change happened in the buffer displayed
in that window.



  reply	other threads:[~2015-11-06 15:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151106093011.17282.48378@vcs.savannah.gnu.org>
     [not found] ` <E1ZudLX-0004XR-KP@vcs.savannah.gnu.org>
2015-11-06 14:18   ` [Emacs-diffs] master 29c360e: Ensure redisplay after "C-x C-e" Stefan Monnier
2015-11-06 14:31     ` Eli Zaretskii
2015-11-06 14:53       ` Artur Malabarba
2015-11-06 15:30         ` Eli Zaretskii [this message]
2015-11-06 16:11           ` Artur Malabarba
2015-11-06 16:30             ` Eli Zaretskii
2015-11-06 19:25               ` Eli Zaretskii
2015-11-07 23:41                 ` Stefan Monnier
2015-11-08  3:36                   ` Eli Zaretskii
2015-11-08  9:23                     ` David Kastrup
2015-11-08 15:54                       ` Eli Zaretskii
2015-11-08 15:55                       ` Drew Adams
2015-11-08 16:07                         ` David Kastrup
2015-11-08 22:25                     ` Stefan Monnier
2015-11-09  3:32                       ` Eli Zaretskii
2015-11-06 15:33         ` Stefan Monnier
2015-11-06 15:30       ` Stefan Monnier
2015-11-06 15:47         ` Eli Zaretskii
2015-11-06 15:54           ` Eli Zaretskii
2015-11-06 21:47           ` Stefan Monnier
2015-11-07  9:07             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83si4jqh5b.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).