From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 040e0d6: Fix 'toggle-save-place' Date: Thu, 25 Feb 2016 18:09:44 +0200 Message-ID: <83si0gg4af.fsf@gnu.org> References: <20160224205710.26753.62720@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1456416605 5588 80.91.229.3 (25 Feb 2016 16:10:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Feb 2016 16:10:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 25 17:10:05 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aYyUN-00016h-RQ for ged-emacs-devel@m.gmane.org; Thu, 25 Feb 2016 17:10:03 +0100 Original-Received: from localhost ([::1]:44137 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYyUN-0007P1-7m for ged-emacs-devel@m.gmane.org; Thu, 25 Feb 2016 11:10:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYyU9-0007Ov-CS for emacs-devel@gnu.org; Thu, 25 Feb 2016 11:09:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYyU5-0000AC-Bp for emacs-devel@gnu.org; Thu, 25 Feb 2016 11:09:49 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYyU5-0000A7-8V; Thu, 25 Feb 2016 11:09:45 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4891 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aYyU4-0002D5-Gi; Thu, 25 Feb 2016 11:09:44 -0500 In-reply-to: (message from Stefan Monnier on Thu, 25 Feb 2016 08:44:37 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200659 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Thu, 25 Feb 2016 08:44:37 -0500 > > > +;;;###autoload > > (defun toggle-save-place (&optional parg) ;FIXME: save-place-local-mode! > > As can be seen in the comment, I think this name should be changed (and > the implementation should use define-minor-mode), so I suggest we don't > autoload this until we've fixed the naming. It makes no sense not to autoload it, because then there's no way for users to turn save-place in a single buffer. Previously, users needed to load saveplace.el to have the feature, so an autoload was not needed. But the changes which switched to save-place-mode invalidated that paradigm, and created a deficiency, which I fixed. (They also broke the command, which I also fixed.) I have nothing against having a local mode, but I don't have time to work on this now, so patches are very welcome. Thanks.