From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-25 10597c9: Don't use 'find-program' Date: Tue, 12 Apr 2016 05:29:51 +0300 Message-ID: <83shyrftk0.fsf@gnu.org> References: <20160411164301.22548.38008@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1460428257 24037 80.91.229.3 (12 Apr 2016 02:30:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Apr 2016 02:30:57 +0000 (UTC) Cc: rgm@gnu.org, emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 12 04:30:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1apo6P-0002Qa-AU for ged-emacs-devel@m.gmane.org; Tue, 12 Apr 2016 04:30:53 +0200 Original-Received: from localhost ([::1]:39336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apo6O-0008MK-Mp for ged-emacs-devel@m.gmane.org; Mon, 11 Apr 2016 22:30:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apo5y-0008K8-P5 for emacs-devel@gnu.org; Mon, 11 Apr 2016 22:30:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apo5v-0002NF-JQ for emacs-devel@gnu.org; Mon, 11 Apr 2016 22:30:26 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apo5v-0002N8-Fg; Mon, 11 Apr 2016 22:30:23 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1617 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1apo5u-0005bv-6J; Mon, 11 Apr 2016 22:30:22 -0400 In-reply-to: (message from Drew Adams on Mon, 11 Apr 2016 15:00:33 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202860 Archived-At: > Date: Mon, 11 Apr 2016 15:00:33 -0700 (PDT) > From: Drew Adams > Cc: Eli Zaretskii > > > (Personally I think renaming it to grep-find-program was a too-literal > > adherence to the namespace convention. It is the find program, it just > > happened to live in grep.el. Its general usefulness is reflected in the > > autoload. Maybe you'd be happier moving it to some find*.el file.) > > +1. It should be called `find-program', IMO. > > If there is really a need for a separate such variable that is > specific to `grep' (in addition to a more general such variable, > for most find-program uses), then _that_ variable could be named > `grep-find-program'. The variable I renamed is specific to grep.el. That other files use it is a bug in itself.