From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: rgm@gnu.org, emacs-devel@gnu.org
Subject: Re: emacs-25 10597c9: Don't use 'find-program'
Date: Tue, 12 Apr 2016 05:29:51 +0300 [thread overview]
Message-ID: <83shyrftk0.fsf@gnu.org> (raw)
In-Reply-To: <d5161d13-4d71-415c-94d8-48baf3816cea@default> (message from Drew Adams on Mon, 11 Apr 2016 15:00:33 -0700 (PDT))
> Date: Mon, 11 Apr 2016 15:00:33 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> > (Personally I think renaming it to grep-find-program was a too-literal
> > adherence to the namespace convention. It is the find program, it just
> > happened to live in grep.el. Its general usefulness is reflected in the
> > autoload. Maybe you'd be happier moving it to some find*.el file.)
>
> +1. It should be called `find-program', IMO.
>
> If there is really a need for a separate such variable that is
> specific to `grep' (in addition to a more general such variable,
> for most find-program uses), then _that_ variable could be named
> `grep-find-program'.
The variable I renamed is specific to grep.el. That other files use
it is a bug in itself.
next prev parent reply other threads:[~2016-04-12 2:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160411164301.22548.38008@vcs.savannah.gnu.org>
[not found] ` <E1apevV-0005sL-3G@vcs.savannah.gnu.org>
2016-04-11 21:56 ` emacs-25 10597c9: Don't use 'find-program' Glenn Morris
2016-04-11 22:00 ` Drew Adams
2016-04-12 2:29 ` Eli Zaretskii [this message]
2016-04-16 11:57 ` Eli Zaretskii
2016-04-16 17:40 ` Glenn Morris
2016-04-16 18:57 ` Eli Zaretskii
2016-04-17 17:15 ` Glenn Morris
2016-04-17 17:39 ` Eli Zaretskii
2016-04-18 4:39 ` Paul Eggert
2016-04-18 18:25 ` Eli Zaretskii
2016-04-18 16:10 ` Glenn Morris
2016-04-18 16:16 ` Glenn Morris
2016-04-18 18:47 ` Eli Zaretskii
2016-04-18 16:50 ` Glenn Morris
2016-04-18 18:50 ` Eli Zaretskii
2016-04-20 19:07 ` Glenn Morris
2016-04-20 19:24 ` Eli Zaretskii
2016-04-20 19:30 ` Stefan Monnier
2016-04-20 19:40 ` Eli Zaretskii
2016-04-20 20:08 ` Stefan Monnier
2016-04-20 22:54 ` John Wiegley
2016-04-18 18:45 ` Eli Zaretskii
2016-04-20 19:27 ` Dmitry Gutov
2016-04-20 19:37 ` Eli Zaretskii
2016-04-20 19:59 ` Stefan Monnier
2016-04-20 20:06 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shyrftk0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).