From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Building Emacs on MSYS2 (was: Build failure for Emacs master) Date: Thu, 14 Apr 2016 19:15:17 +0300 Message-ID: <83shyodv56.fsf@gnu.org> References: <56CCD91E.6070507@alice.it> <83egc2ixji.fsf@gnu.org> <56CD798D.7060102@alice.it> <56CD8408.1000701@alice.it> <83wppuggb4.fsf@gnu.org> <56CE2CA7.5050906@alice.it> <83io1cg2pt.fsf@gnu.org> <56DA0327.2030009@alice.it> <83oaatxu72.fsf@gnu.org> <570C4307.6050907@alice.it> <83k2k2g82s.fsf@gnu.org> <570EA823.1010404@alice.it> <570EBADD.2060604@cs.ucla.edu> <570EC198.5090407@alice.it> <570EF300.3050104@cs.ucla.edu> <570F4EC7.3060403@alice.it> <83twj4dx7q.fsf@gnu.org> <878u0gyyge.fsf_-_@wanadoo.es> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1460650576 28844 80.91.229.3 (14 Apr 2016 16:16:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Apr 2016 16:16:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?iso-8859-1?Q?=D3scar?= Fuentes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 14 18:16:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aqjwB-00044V-B7 for ged-emacs-devel@m.gmane.org; Thu, 14 Apr 2016 18:16:11 +0200 Original-Received: from localhost ([::1]:42473 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqjwA-0007BL-FP for ged-emacs-devel@m.gmane.org; Thu, 14 Apr 2016 12:16:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqjvm-00075D-QU for emacs-devel@gnu.org; Thu, 14 Apr 2016 12:15:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqjvh-0000N5-MO for emacs-devel@gnu.org; Thu, 14 Apr 2016 12:15:46 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqjvh-0000N1-IF; Thu, 14 Apr 2016 12:15:41 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1185 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aqjvh-0002jQ-0n; Thu, 14 Apr 2016 12:15:41 -0400 In-reply-to: <878u0gyyge.fsf_-_@wanadoo.es> (message from =?iso-8859-1?Q?=D3scar?= Fuentes on Thu, 14 Apr 2016 17:58:09 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202913 Archived-At: > From: Óscar Fuentes > Date: Thu, 14 Apr 2016 17:58:09 +0200 > > Currently this is the code for configuring the build of emacs-git on > MSYS2 MinGW-packages: > > build() { > [[ -d "${srcdir}/build-${MINGW_CHOST}" ]] && rm -rf "${srcdir}/build-${MINGW_CHOST}" > mkdir -p "${srcdir}/build-${MINGW_CHOST}" > cd "build-${MINGW_CHOST}" > > local with_wide_int='no' > > if test "${CARCH}" == 'x86_64'; then > with_wide_int='yes' > fi > > CPPFLAGS="-DNDEBUG -isystem ${MINGW_PREFIX}/include" > CFLAGS="-pipe -O3 -fomit-frame-pointer -funroll-loops" > LDFLAGS="-s -Wl,-s" > "${srcdir}/${_realname}/configure" \ > --prefix="${MINGW_PREFIX}" \ > --build="${MINGW_CHOST}" \ > --with-wide-int="${with_wide_int}" \ > --with-sound="yes" \ > --with-file-notification="yes" \ > --without-gpm \ > --without-gconf \ > --without-gsettings \ > --without-selinux > > make > } > > Apart from setting with_wide_int and adding some (unnecessary, IMHO) > optimization options, it looks like a fairly standard configuration. Actually, I see nothing standard at all here. I see no reason for _any_ of the options, neither in CPPFLAGS nor in CFLAGS. They are all potential source of trouble for the uninitiated. (If there are real reasons for them, they must be bugs that should be reported and fixed upstream.) And why "-s" in LDFLAGS? that's just hostile to developers, since no user can possibly provide any details about any bugs. (Of course, this is in line with -fomit-frame-pointer, which is also a killer for any attempts to debug.) And all the switches to 'configure', with the single exception of --prefix (assuming that it has the correct /d/foo/bar form and points to the MinGW directory, not to MSYS2 directory) are simply clutter, they are no-ops at best and potential trouble at worst. Bottom line, I really don't like this script. > The package contains two patches too. This one that looks like trying to > avoid a link problem: > > > --- src/image.c.orig 2014-10-15 14:18:29.088716000 +0200 > +++ src/image.c 2014-10-15 15:54:12.407522800 +0200 > @@ -7862,7 +7862,7 @@ > }; > > #if defined HAVE_NTGUI && defined WINDOWSNT > -static bool init_imagemagick_functions (void); > +#define init_imagemagick_functions NULL > #else > #define init_imagemagick_functions NULL > #endif What link problem is that? Why those who use the official procedure never have or report it? > and this one that seems related to locating the source directory: > > --- src/lread.c.orig 2014-11-04 20:29:22.129549000 +0100 > +++ src/lread.c 2014-11-04 22:33:07.346414100 +0100 > @@ -4351,6 +4351,12 @@ > } /* Vinstallation_directory != Vsource_directory */ > > } /* if Vinstallation_directory */ > + else > + { > + Vsource_directory > + = Fexpand_file_name (build_string ("../"), > + Fcar (decode_env_path (0, PATH_DATA, 0))); > + } > } > else /* !initialized */ > { What problem does this try to fix, and why? > I can change the emacs-git package for not adding those optimization > options and not setting with-wide-int. Do you think that's enough? I think this should simply invoke the commands shown in nt/INSTALL.W64, and that's it. IOW, it should run the official procedure, and if there are reasons to change that, those reasons should be reported and discussed. > > Failing that, please consider > > switching back to what the project recommends, what is documented in > > the relevant INSTALL documents. > > Because MSYS2 does not distribute binaries for emacs-git, I guess that > the number of people who currently uses the PKGBUILD shown above is very > small. I have similar issues with the MSYS2 procedure for building official releases. Thanks.