From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 2f5e0b1: Improve case-insensitive checks (Bug#24441)
Date: Mon, 14 Nov 2016 22:43:01 +0200 [thread overview]
Message-ID: <83shqthjxm.fsf@gnu.org> (raw)
In-Reply-To: <2cee3b57-fbda-a604-699b-23a06a982f3b@cornell.edu> (message from Ken Brown on Mon, 14 Nov 2016 15:22:03 -0500)
> From: Ken Brown <kbrown@cornell.edu>
> Date: Mon, 14 Nov 2016 15:22:03 -0500
> Cc: emacs-devel@gnu.org
>
> On 11/14/2016 2:30 PM, Eli Zaretskii wrote:
> > I've reverted that commit. I see no reason in your changes, which
> > effectively removed code and useful documentation and comments, on
> > which Ken labored, without any discussion.
>
> Thanks. I think there are some useful ideas in Paul's commit, but I
> also see some problems. I'll write specific comments in reply to his
> commit message.
I'd be glad to see the solution improved, of course. But the ways to
improve it should be discussed first and committed only after that,
especially when the changes effectively disable portions of the
previous commit and remove other portions.
next prev parent reply other threads:[~2016-11-14 20:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 19:30 [Emacs-diffs] master 2f5e0b1: Improve case-insensitive checks (Bug#24441) Eli Zaretskii
2016-11-14 20:22 ` Ken Brown
2016-11-14 20:43 ` Eli Zaretskii [this message]
2016-11-14 20:54 ` Paul Eggert
2016-11-14 21:07 ` Ken Brown
2016-11-14 22:33 ` Ken Brown
2016-11-15 16:07 ` Eli Zaretskii
2016-11-15 19:15 ` Ken Brown
2016-11-15 20:26 ` Eli Zaretskii
2016-11-19 19:29 ` Philipp Stephani
[not found] <20161114170952.20595.32286@vcs.savannah.gnu.org>
[not found] ` <20161114170952.6729A220179@vcs.savannah.gnu.org>
2016-11-14 21:03 ` Ken Brown
2016-11-14 21:53 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shqthjxm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).