* Please test GC_CHECK_MARKED_OBJECTS
@ 2016-12-21 2:53 Daniel Colascione
2016-12-21 17:16 ` Eli Zaretskii
2016-12-21 20:18 ` Eli Zaretskii
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Colascione @ 2016-12-21 2:53 UTC (permalink / raw)
To: emacs-devel
GC_CHECK_MARKED_OBJECTS is broken with threads: PVEC_THREAD objects are
not found via mem_find (but they should be?) and GC_CHECK_MARKED_OBJECTS
assumes that any such vectorlike object must be a subr. I think it's
been broken since the threading branch landed. Maybe we should enable
GC_CHECK_MARKED_OBJECTS by defaults when --enable-checking.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Please test GC_CHECK_MARKED_OBJECTS
2016-12-21 2:53 Please test GC_CHECK_MARKED_OBJECTS Daniel Colascione
@ 2016-12-21 17:16 ` Eli Zaretskii
2016-12-21 19:22 ` Stefan Monnier
2016-12-21 20:18 ` Eli Zaretskii
1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2016-12-21 17:16 UTC (permalink / raw)
To: Daniel Colascione; +Cc: emacs-devel
> From: Daniel Colascione <dancol@dancol.org>
> Date: Tue, 20 Dec 2016 18:53:15 -0800
>
> GC_CHECK_MARKED_OBJECTS is broken with threads: PVEC_THREAD objects are
> not found via mem_find (but they should be?) and GC_CHECK_MARKED_OBJECTS
> assumes that any such vectorlike object must be a subr. I think it's
> been broken since the threading branch landed.
Could you please file a bug report with all the details of the
failures you saw?
> Maybe we should enable GC_CHECK_MARKED_OBJECTS by defaults when
> --enable-checking.
Could be. Does that incur any significant slow-down?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Please test GC_CHECK_MARKED_OBJECTS
2016-12-21 2:53 Please test GC_CHECK_MARKED_OBJECTS Daniel Colascione
2016-12-21 17:16 ` Eli Zaretskii
@ 2016-12-21 20:18 ` Eli Zaretskii
1 sibling, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2016-12-21 20:18 UTC (permalink / raw)
To: Daniel Colascione; +Cc: emacs-devel
> From: Daniel Colascione <dancol@dancol.org>
> Date: Tue, 20 Dec 2016 18:53:15 -0800
>
> GC_CHECK_MARKED_OBJECTS is broken with threads: PVEC_THREAD objects are
> not found via mem_find (but they should be?) and GC_CHECK_MARKED_OBJECTS
> assumes that any such vectorlike object must be a subr.
I think I fixed this in master, please test.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-21 20:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-21 2:53 Please test GC_CHECK_MARKED_OBJECTS Daniel Colascione
2016-12-21 17:16 ` Eli Zaretskii
2016-12-21 19:22 ` Stefan Monnier
2016-12-21 20:18 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).