unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Emacs-devel@gnu.org
Subject: Re: preferring https: to http: in commit messages for gnu.org
Date: Sun, 15 Oct 2017 17:25:09 +0300	[thread overview]
Message-ID: <83shekh4je.fsf@gnu.org> (raw)
In-Reply-To: <61bfc72e-b21f-3fb9-25b7-b718bb69d85b@cs.ucla.edu> (message from Paul Eggert on Sun, 15 Oct 2017 00:14:04 -0700)

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sun, 15 Oct 2017 00:14:04 -0700
> 
> I installed the attached into the default Git commit hooks to help remind us 
> (and particularly to remind me, since I write a fair number of these things) 
> that https: should be preferred to http: in commit-message URLs that point to 
> gnu.org or fsf.org web sites.
> 
> +  {
> +    if (match($0, unsafe_gnu_url)) {
> +      url = substr($0, RSTART, RLENGTH)
> +      printf "Use https: URL instead of '\''%s'\'' in commit message\n", url
> +      status = 1

"status = 1" means the commit will be rejected, am I right?  If so,
please don't fail commits because of that, it's too radical.  E.g., I
frequently cite URLs in commit messages, copying them from the
browser, and this hook change will now require me to look for
alternative URLs, if they exist, re-commit, perhaps find out that
someone already pushed to upstream, then pull, push again...  It's an
annoyance.  I cannot be responsible for every useful URL out there.

Thanks.



  reply	other threads:[~2017-10-15 14:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-15  7:14 preferring https: to http: in commit messages for gnu.org Paul Eggert
2017-10-15 14:25 ` Eli Zaretskii [this message]
2017-10-16  7:07   ` Paul Eggert
2017-10-16 15:09     ` Eli Zaretskii
2017-10-16 15:19       ` Yuri Khan
2017-10-16 16:20         ` Robert Pluim
2017-10-16 18:47           ` Paul Eggert
2017-10-16 18:54             ` Eli Zaretskii
2017-10-16 23:15       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83shekh4je.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=Emacs-devel@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).