From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 108ce84 2/2: xref--next-error-function: Move xref's window point
Date: Wed, 28 Feb 2018 17:28:52 +0200 [thread overview]
Message-ID: <83sh9lyvyj.fsf@gnu.org> (raw)
In-Reply-To: <1528a8cd-493c-4219-6eb3-693a28aca5a5@yandex.ru> (message from Dmitry Gutov on Wed, 28 Feb 2018 04:13:22 +0200)
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 28 Feb 2018 04:13:22 +0200
>
> Eli, what would you say about backporting this to emacs-26?
>
> This change is limited in scope, it fixes annoying "looping" behavior
> I've seen in some cases, and it adds window point movement you've asked
> for before in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20489#110
>
> > branch: master
> > commit 108ce84432d597f92637ea74bd0a094224d157de
> > Author: Dmitry Gutov <dgutov@yandex.ru>
> > Commit: Dmitry Gutov <dgutov@yandex.ru>
> >
> > xref--next-error-function: Move xref's window point
> >
> > * lisp/progmodes/xref.el (xref--next-error-function): Move
> > xref's window point if it's visible. When we don't do that,
> > navigation can start looping after a while.
Sorry, this doesn't tell which problem(s) it attempts to fix, and
there are no references to discussions or bug reports that could help
me figure that out. Without that, I cannot make up my mind about the
importance of this fix.
next prev parent reply other threads:[~2018-02-28 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180228020456.19376.79157@vcs0.savannah.gnu.org>
[not found] ` <20180228020457.59950207B1@vcs0.savannah.gnu.org>
2018-02-28 2:13 ` [Emacs-diffs] master 108ce84 2/2: xref--next-error-function: Move xref's window point Dmitry Gutov
2018-02-28 15:28 ` Eli Zaretskii [this message]
2018-02-28 15:58 ` Dmitry Gutov
2018-03-02 13:39 ` Eli Zaretskii
2018-03-02 14:10 ` Dmitry Gutov
2018-03-02 14:50 ` Eli Zaretskii
2018-03-03 0:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sh9lyvyj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).