From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: schwab@suse.de, michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: emacs-26 c87d04e: Avoid aborts in 'md5'
Date: Thu, 01 Mar 2018 05:39:00 +0200 [thread overview]
Message-ID: <83sh9kxy5n.fsf@gnu.org> (raw)
In-Reply-To: <f9b035f3-fc34-08c2-bde1-732ed917401b@cs.ucla.edu> (message from Paul Eggert on Wed, 28 Feb 2018 14:14:46 -0800)
> Cc: schwab@suse.de, michael.albinus@gmx.de, emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 28 Feb 2018 14:14:46 -0800
>
> On 02/28/2018 12:35 PM, Eli Zaretskii wrote:
> > That's not what I meant. I meant that as long as the code is frozen
> > in its current form, nothing is gained by omitting 'else'.
>
> I'm puzzled, since my patch inserts 'else', and yet you appear to be
> objecting to it on the grounds that nothing is gained by omitting
> 'else'. I must be misunderstanding.
"Nothing is gained" was Andreas's argument, not mine.
> For the case we're talking about, it's not possible for the object to be
> a string, so although it might be appropriate to have an eassert
> (STRINGP (...)) to verify that the impossible does not happen (to help
> future-proof the code, say), we shouldn't need a runtime check in
> production code.
I don't want a function called from half a dozen places, which
generates a string from at least 3 different object types, to become a
cause for an assertion violation or worse. It is a large and
not-so-simple function, where drawing such conclusions could yield
mistakes.
So let's please stop this particular bike-shedding and leave the code
alone. There's nothing wrong with it.
next prev parent reply other threads:[~2018-03-01 3:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180227164448.16622.42058@vcs0.savannah.gnu.org>
[not found] ` <20180227164448.E4B45207B1@vcs0.savannah.gnu.org>
2018-02-28 8:30 ` emacs-26 c87d04e: Avoid aborts in 'md5' Michael Albinus
2018-02-28 8:49 ` Andreas Schwab
2018-02-28 9:09 ` Michael Albinus
2018-02-28 9:15 ` Andreas Schwab
2018-02-28 15:55 ` Eli Zaretskii
2018-02-28 16:32 ` Andreas Schwab
2018-02-28 17:24 ` Eli Zaretskii
2018-02-28 19:14 ` Paul Eggert
2018-02-28 20:35 ` Eli Zaretskii
2018-02-28 22:14 ` Paul Eggert
2018-03-01 3:39 ` Eli Zaretskii [this message]
2018-02-28 15:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sh9kxy5n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).