From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master bb591f139f: Enhance CC Mode's fontification, etc., of unterminated strings. Date: Wed, 23 May 2018 17:52:39 +0300 Message-ID: <83sh6ictl4.fsf@gnu.org> References: <20180522174054.GA4504@ACM> <877envijii.fsf@gmail.com> <83zi0rcwmx.fsf@gnu.org> <87zi0rh1ys.fsf@gmail.com> <871se31gjx.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1527087711 7495 195.159.176.226 (23 May 2018 15:01:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 23 May 2018 15:01:51 +0000 (UTC) Cc: acm@muc.de, tino.calancha@gmail.com, emacs-devel@gnu.org To: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 23 17:01:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fLVGs-0001pz-3X for ged-emacs-devel@m.gmane.org; Wed, 23 May 2018 17:01:46 +0200 Original-Received: from localhost ([::1]:33938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLVIz-0000fa-4l for ged-emacs-devel@m.gmane.org; Wed, 23 May 2018 11:03:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLV81-0000xJ-Pf for emacs-devel@gnu.org; Wed, 23 May 2018 10:52:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLV81-00049q-3l for emacs-devel@gnu.org; Wed, 23 May 2018 10:52:37 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLV7v-00047t-A9; Wed, 23 May 2018 10:52:31 -0400 Original-Received: from [176.228.60.248] (port=2117 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fLV7u-0007a7-Oe; Wed, 23 May 2018 10:52:31 -0400 In-reply-to: <871se31gjx.fsf@gmail.com> (joaotavora@gmail.com) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225603 Archived-At: > From: joaotavora@gmail.com (João Távora) > Cc: emacs-devel@gnu.org, tino.calancha@gmail.com > Date: Tue, 22 May 2018 23:17:22 +0100 > > > I just pushed this change to master and though it's not perfect, I'm > pretty happy with the result. Here's readable output of M-x > ert-describe-test for the test that Alan is investigating: > > electric-pair-autowrapping-5-at-point-2-in-c++-mode-in-strings is a > test defined in `electric-tests.elc'. > > Electricity test in a `c++-mode' buffer. > > Start with point at 2 in a 5-char-long buffer > like this one: > > |"foo"| (buffer start and end are denoted by `|') > > Now call this: > > #'(lambda nil > (electric-pair-mode 1) > (mark-sexp 1)) > > Now press the key for: " > > The buffer's contents should become: > > |""foo""| > > , and point should be at 3. Thanks, LGTM.