From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Debugging printing to stderr prior glyph row values .... Date: Thu, 23 May 2019 21:38:25 +0300 Message-ID: <83sgt5584e.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="123044"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Keith David Bershatsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 23 20:38:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTsbi-000VtG-6c for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 20:38:26 +0200 Original-Received: from localhost ([127.0.0.1]:41753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTsbh-0001nn-4C for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 14:38:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTsba-0001nU-C3 for emacs-devel@gnu.org; Thu, 23 May 2019 14:38:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hTsba-0000Au-1e; Thu, 23 May 2019 14:38:18 -0400 Original-Received: from [176.228.60.248] (port=3154 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hTsbX-00081z-ME; Thu, 23 May 2019 14:38:16 -0400 In-reply-to: (message from Keith David Bershatsky on Thu, 23 May 2019 10:23:03 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236941 Archived-At: > Date: Thu, 23 May 2019 10:23:03 -0700 > From: Keith David Bershatsky > Cc: emacs-devel@gnu.org > > I will add a test for the `used` row member to ensure that it is positive. The crashing reported in the initial post only happens somtimes, so I'll need to do some further testing. Did you look at the problematic row with the GDB command "pgrowx"? It's important to understand what kind of glyphs are in that row and how many of them do you have there. > I am looking to programmatically distinguish between the following three types of consecutive rows: (1) the penultimate row _not_ ending in ZV that immediately precedes a row with _only_ ZV; (2) the last row that contains _only_ ZV; and, (3) rows that follow a row with _only_ ZV. There's a 4th case: when a row ends at ZV, but does have glyphs. This happens, for example, when visiting a file that doesn't end in a newline. > A better method of determining row_at_zv_p (without consulting ROW - 1) would be appreciated, if such a test exists. I don't understand why you don't just look at the ends_at_zv_p flag, that's what it's for.