From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Tue, 03 Sep 2019 17:56:05 +0300 Message-ID: <83sgpd77ju.fsf@gnu.org> References: <83mufr9gya.fsf@gnu.org> <03a80221-5222-9b8b-86a1-67cef18df463@gmx.at> <83zhjp937v.fsf@gnu.org> <8acd9fc1-e6ce-9a86-cfb6-e00a672c154a@gmx.at> <20190901122628.aynhzwwpvqbgyydh@Ergus> <20190902110504.zniyfmd7bi53iyxe@Ergus> <83zhjm7juc.fsf@gnu.org> <20190903053331.i36bn2i5ytta2ma7@Ergus> <5fa51eff-75bc-9760-3e6e-af343dedc12e@gmx.at> <20190903112337.txj2ahuv547tbwy7@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="36058"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 03 16:56:46 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i5AEf-0009G5-EK for ged-emacs-devel@m.gmane.org; Tue, 03 Sep 2019 16:56:45 +0200 Original-Received: from localhost ([::1]:47104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5AEe-0001oA-2J for ged-emacs-devel@m.gmane.org; Tue, 03 Sep 2019 10:56:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48402) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5AEA-0001ng-P4 for emacs-devel@gnu.org; Tue, 03 Sep 2019 10:56:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i5AEA-00089Y-Bt; Tue, 03 Sep 2019 10:56:14 -0400 Original-Received: from [176.228.60.248] (port=2200 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i5AE9-0007l8-N9; Tue, 03 Sep 2019 10:56:14 -0400 In-reply-to: <20190903112337.txj2ahuv547tbwy7@Ergus> (message from Ergus on Tue, 3 Sep 2019 13:23:37 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239813 Archived-At: > Date: Tue, 3 Sep 2019 13:23:37 +0200 > From: Ergus > Cc: Eli Zaretskii , emacs-devel@gnu.org > > I found also that we where very concerned about what happen when > merging, but there was not any comment about face_id changes in other > cases (like reassign). > > For example, when we select a word in the middle of a line. The > extend_face will be set to the region face when the iterator iterates > throw the word, but then it shouldn't be extended at EOL. We need to recalculate extend_face_id at the same places where we recalculate face_id. > maybe we should test only the last face in the line before EOL to check > for the extend flag; but then the extend_face_id will be again an > intrinsic parameter of that face. How do you know it's "the last face"?