From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: VOTE: Changing completions-common-part face's default Date: Sat, 09 Nov 2019 08:52:42 +0200 Message-ID: <83sgmxa6dh.fsf@gnu.org> References: <4c5631d4-9dfd-04c6-c573-b83c67fcc2fa@yandex.ru> <87pni7p83l.fsf@gmail.com> <87h83ipoi0.fsf@gmail.com> <93235eb5-8e04-7182-e2a4-49fbe610ee2b@yandex.ru> <28d4ae09-daca-324b-2fa6-9d7138d710fa@yandex.ru> <834kzeb1cc.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101730"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 09 07:53:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iTKcG-000QJl-5Q for ged-emacs-devel@m.gmane.org; Sat, 09 Nov 2019 07:53:00 +0100 Original-Received: from localhost ([::1]:35134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTKcE-0004h8-C3 for ged-emacs-devel@m.gmane.org; Sat, 09 Nov 2019 01:52:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59506) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTKc7-0004gt-9M for emacs-devel@gnu.org; Sat, 09 Nov 2019 01:52:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iTKc7-0000KY-15; Sat, 09 Nov 2019 01:52:51 -0500 Original-Received: from [176.228.60.248] (port=2571 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iTKc6-0001q5-Dz; Sat, 09 Nov 2019 01:52:50 -0500 In-reply-to: (message from Stefan Monnier on Fri, 08 Nov 2019 16:42:50 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242027 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Fri, 08 Nov 2019 16:42:50 -0500 > > Concretely the patch I'm suggesting is the one below, which makes it so > the "common-part" (e.g. the common prefix in the case basic completion) > of the completions has a blue3 foreground rather than being identical to > `default` Hm... so the "common part" will be highlighted as blueish and the "first difference" will stay just bold? Does that look good? IOW, will the bold character be seen right next to a blue one? Maybe we should also change the default definition of the first-difference face? I'd actually expect this face to use the background, because that's how other applications behave, and I thought this change was motivated by that? Also, what will this do to the output of the more aggressive completion styles? > we'd also want to find a color for the dark background case, Right.