From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master d582356: * src/fns.c (Frandom): Handle bignum `limit`s
Date: Sat, 06 Mar 2021 10:44:48 +0200
Message-ID: <83sg58wu0v.fsf@gnu.org>
References: <20210305170955.27732.27579@vcs0.savannah.gnu.org>
 <20210305170957.AF99920E1B@vcs0.savannah.gnu.org>
 <CAOqdjBfocJseE-Ht-9f-ga+R-5LduFqBqgDbTA5UJPMeS6i0vA@mail.gmail.com>
 <jwv35x9e63h.fsf-monnier+emacs@gnu.org>
 <CAOqdjBfEYYedrV6zktd8woz3eWXAYfvd39NHiDkcT4fZ5hRmaw@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="35716"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
To: Pip Cet <pipcet@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 06 09:46:50 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lISaH-0009AP-AL
	for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Mar 2021 09:46:49 +0100
Original-Received: from localhost ([::1]:41490 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lISaG-0002HA-Ai
	for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Mar 2021 03:46:48 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53488)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lISYZ-00013i-Ut
 for emacs-devel@gnu.org; Sat, 06 Mar 2021 03:45:03 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36012)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lISYZ-00034A-Mh; Sat, 06 Mar 2021 03:45:03 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2450
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lISYY-0004Bf-G5; Sat, 06 Mar 2021 03:45:03 -0500
In-Reply-To: <CAOqdjBfEYYedrV6zktd8woz3eWXAYfvd39NHiDkcT4fZ5hRmaw@mail.gmail.com>
 (message from Pip Cet on Sat, 6 Mar 2021 07:42:20 +0000)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:266060
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/266060>

> From: Pip Cet <pipcet@gmail.com>
> Date: Sat, 6 Mar 2021 07:42:20 +0000
> Cc: emacs-devel@gnu.org
> 
> * src/buffer.c (Fgenerate_new_buffer_name): Call intern ("random").

Previously, Fgenerate_new_buffer_name couldn't cause GC, but with this
change it can, because the modified code calls funcall.  For the same
reason, it could now QUIT, where it previously couldn't.  So this
change would need to be accompanied by auditing the C callers of
Fgenerate_new_buffer_name, to make sure they don't use any code that
doesn't expect any of these 2 events to happen (such as 'char *'
pointers lying around, which might become invalid after GC).