From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] icomplete-vertical
Date: Tue, 06 Apr 2021 15:21:48 +0300
Message-ID: <83sg43bo2r.fsf@gnu.org>
References: <dff0cccf05b51da8e080@heytings.org> <87h7kkwcy1.fsf@posteo.net>
 <dff0cccf059a4de2b0f3@heytings.org>
 <CADwFkmneNA91i7v-fqLhuTEqbU0PDA-pkq6hsQZBkHi=b-9pyQ@mail.gmail.com>
 <83tuokb0uk.fsf@gnu.org> <acf6f0cd7e34cb328d02@heytings.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="19395"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Gregory Heytings <gregory@heytings.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 14:23:39 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lTkk7-0004ul-12
	for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 14:23:39 +0200
Original-Received: from localhost ([::1]:49928 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lTkk6-0001aW-0y
	for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 08:23:38 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36094)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lTkiP-0000hq-OE
 for emacs-devel@gnu.org; Tue, 06 Apr 2021 08:21:58 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49163)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lTkiO-00034d-WF; Tue, 06 Apr 2021 08:21:53 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4145
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lTkiN-0006so-9f; Tue, 06 Apr 2021 08:21:52 -0400
In-Reply-To: <acf6f0cd7e34cb328d02@heytings.org> (message from Gregory
 Heytings on Tue, 06 Apr 2021 07:44:42 +0000)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:267465
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/267465>

> Date: Tue, 06 Apr 2021 07:44:42 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: emacs-devel@gnu.org
> 
> Okay, I did not know that there is a strict rule against advice.  Here is 
> the updated patch, which uses a hook instead.  This makes the code even 
> more flexible.

Thanks.  A minor nit: every new or modified defcustom should have a
suitable :version tag.