Re: master 65fe177: Don't use pdumper-stats with unexec

Re: master 65fe177: Don't use pdumper-stats with unexec

[Lars Ingebrigtsen]

eliz@gnu.org (Eli Zaretskii) writes:

>     Don't use pdumper-stats with unexec
>
>     * lisp/emacs-lisp/bytecomp.el (byte-compile-refresh-preloaded): Check if
>     pdumper-stats is bound before using it.

Some recent change (possibly this patch) leads to the following test
failure:

1 unexpected results:
   FAILED  bytecomp-tests--dest-mountpoint

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 65fe177: Don't use pdumper-stats with unexec

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 02 May 2021 12:20:51 +0200
> Cc: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
> 
> eliz@gnu.org (Eli Zaretskii) writes:
> 
> >     Don't use pdumper-stats with unexec
> >
> >     * lisp/emacs-lisp/bytecomp.el (byte-compile-refresh-preloaded): Check if
> >     pdumper-stats is bound before using it.
> 
> Some recent change (possibly this patch) leads to the following test
> failure:
> 
> 1 unexpected results:
>    FAILED  bytecomp-tests--dest-mountpoint

That test is skipped on the systems to which I have access, so someone
else will have to debug the failure.  Or does the detailed error
message tell something obvious?

Re: master 65fe177: Don't use pdumper-stats with unexec

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> Some recent change (possibly this patch) leads to the following test
>> failure:
>> 
>> 1 unexpected results:
>>    FAILED  bytecomp-tests--dest-mountpoint
>
> That test is skipped on the systems to which I have access, so someone
> else will have to debug the failure.  Or does the detailed error
> message tell something obvious?

Not really obvious to me, at least:

Test bytecomp-tests--dest-mountpoint backtrace:
  signal(ert-test-failed (((status . 255) (output . "Cannot open load 
  ert-fail(((status . 255) (output . "Cannot open load file: No such f
  (if (eql status 0) nil (ert-fail (list (cons 'status status) (cons '
  (let ((status (call-process bwrap nil t nil "--ro-bind" "/" "/" "--b
  (progn (let ((status (call-process bwrap nil t nil "--ro-bind" "/" "
  (unwind-protect (progn (let ((status (call-process bwrap nil t nil "
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (let* ((input-file (expand-file-name "test.el" directory)) (output-f
  (unwind-protect (let* ((input-file (expand-file-name "test.el" direc
  (let ((directory (make-temp-file "bytecomp-tests-" :directory))) (un
  (let ((bwrap (executable-find "bwrap")) (emacs (expand-file-name inv
  (closure (t) nil (let ((bwrap (executable-find "bwrap")) (emacs (exp
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name bytecomp-tests--dest-mountpoint :docu
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
  command-line()
  normal-top-level()
Test bytecomp-tests--dest-mountpoint condition:
    (ert-test-failed
     ((status . 255)
      (output . "Cannot open load file: No such file or directory, debug\12")))

But perhaps it'll be obvious to Philipp; added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 65fe177: Don't use pdumper-stats with unexec

[Nikolay Kudryavtsev]

That change only touched byte-compile-refresh-preloaded and that 
function does not seem to be on the execution path for that test, more 
so it does not seem to even get called anywhere, apart from the Makefile.

So it's very unlikely that this patch is what triggers the failure. 
Anyway, I'll look into it...

Re: master 65fe177: Don't use pdumper-stats with unexec

[Nikolay Kudryavtsev]

Lars, can you still reproduce this test failure?

Because I so far could not. I've tried both the latest master and some 
revisions from around the time of your report, in case it got fixed in 
the meantime. The test passes fine for me.

Re: master 65fe177: Don't use pdumper-stats with unexec

[Lars Ingebrigtsen]

Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:

> Lars, can you still reproduce this test failure?
>
> Because I so far could not. I've tried both the latest master and some
> revisions from around the time of your report, in case it got fixed in
> the meantime. The test passes fine for me.

Yes, it still fails for me under Debian/bullseye.  To reproduce:

$ sudo apt install bubblewrap
$ cd test/
$ make bytecomp-tests

...
Test bytecomp-tests--dest-mountpoint backtrace:
  signal(ert-test-failed (((status . 255) (output . "Cannot open load 
  ert-fail(((status . 255) (output . "Cannot open load file: No such f
  (if (eql status 0) nil (ert-fail (list (cons 'status status) (cons '

1 unexpected results:
   FAILED  bytecomp-tests--dest-mountpoint


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 65fe177: Don't use pdumper-stats with unexec

[Nikolay Kudryavtsev]

Got myself a bullseye vm. Still no luck reproducing this.

It seems like there is some other factor that triggers the test failure.

Is there anyone here besides Lars who is able to reproduce this?

Re: master 65fe177: Don't use pdumper-stats with unexec

[Lars Ingebrigtsen]

Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:

> Got myself a bullseye vm. Still no luck reproducing this.
>
> It seems like there is some other factor that triggers the test failure.
>
> Is there anyone here besides Lars who is able to reproduce this?

Uhm.  Today I'm not able to reproduce the problem, either.  I reverted
back to a previous Emacs checkout, but I'm not able to reproduce it
with that, either.

So it could have been some transient bug in Debian/bullseye that's now
fixed?  (I saw the problem on two different bullseye machines...)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 65fe177: Don't use pdumper-stats with unexec

[Lars Ingebrigtsen]

Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:

> Got myself a bullseye vm. Still no luck reproducing this.
>
> It seems like there is some other factor that triggers the test failure.

I'd forgotten that it only fails when native-comp is enabled.  That is:

./configure --with-native-compilation
make
cd test
make bytecomp-tests

fails.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master 65fe177: Don't use pdumper-stats with unexec

[Nikolay Kudryavtsev]

That test checks for .elc file presence. Native compile does not 
generate elc's, right?

Re: master 65fe177: Don't use pdumper-stats with unexec

[Lars Ingebrigtsen]

Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:

> That test checks for .elc file presence. Native compile does not
> generate elc's, right?

Yes, it still generates .elc files as normal.  (But then can compile
those .elc files into .eln files afterwards.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no