From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: macOS metal rendering engine in mac port Date: Mon, 24 May 2021 21:03:12 +0300 Message-ID: <83sg2cc8m7.fsf@gnu.org> References: <831r9xjrho.fsf@gnu.org> <5754E85B-9840-416B-B9C1-E6B2B1FC0114@gnu.org> <80A25FCA-2CF4-433F-B82F-4B37ED5BC6DC@gnu.org> <831r9wdrjr.fsf@gnu.org> <83v978ccbc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12174"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, mituharu@math.s.chiba-u.ac.jp, emacs-devel@gnu.org To: Aaron Jensen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 20:07:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llEzA-0002wM-Mb for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 20:07:28 +0200 Original-Received: from localhost ([::1]:53498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llEz9-0005Yx-Ob for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 14:07:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llEvA-0001Ii-U2 for emacs-devel@gnu.org; Mon, 24 May 2021 14:03:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45526) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llEv7-0002OG-KK; Mon, 24 May 2021 14:03:17 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4146 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llEv7-00068I-2T; Mon, 24 May 2021 14:03:17 -0400 In-Reply-To: (message from Aaron Jensen on Mon, 24 May 2021 10:58:23 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269787 Archived-At: > From: Aaron Jensen > Date: Mon, 24 May 2021 10:58:23 -0700 > Cc: emacs-devel@gnu.org, Alan Third , > YAMAMOTO Mitsuharu > > On Mon, May 24, 2021 at 9:43 AM Eli Zaretskii wrote: > > > > Of course. But it also does that for every other face, starting with > > font-lock faces. So something is still amiss here, because 40 is too > > small a number. > > I'm not seeing this. With line numbers off the only call to > merge_faces is for escape-glyph when I use scroll-up-benchmark. I'm on > Alan's surface-stuff branch if that makes any difference. > > > > > Also, what did Emacs do when you collected these numbers, and in which > > > > buffer under what major mode? > > > > > > emacs -Q src/xdisp.c with scroll-up-benchmark > > > > Then you should see font-lock-comment-face, font-lock-keyword-face, > > font-lock-variable-name-face, etc., and calls to merge_face_ref for > > them coming from face_at_buffer_position. > > Yeah, I don't see calls to merge_faces for these. Here's the debug code I added: I said merge_face_ref, not merge_faces. See face_at_buffer_position, which is called whenever the display code finds a new face at some buffer position. I don't know what that branch does; I thought we were talking about the master branch.