From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 28bf387: Tweak Fdirectory_append for efficiency Date: Sat, 24 Jul 2021 19:58:48 +0300 Message-ID: <83sg03y7g7.fsf@gnu.org> References: <8335s3zng8.fsf@gnu.org> <87sg031xrc.fsf@gnus.org> <831r7nzn27.fsf@gnu.org> <87k0lf1wt4.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26365"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 24 18:59:36 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7Kzv-0006dw-GY for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 18:59:35 +0200 Original-Received: from localhost ([::1]:46382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7Kzu-0003YW-H1 for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Jul 2021 12:59:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7KzP-0002uD-Ud for emacs-devel@gnu.org; Sat, 24 Jul 2021 12:59:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45426) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7KzP-0002bk-Mk; Sat, 24 Jul 2021 12:59:03 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2329 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7KzP-0000PQ-AD; Sat, 24 Jul 2021 12:59:03 -0400 In-Reply-To: <87k0lf1wt4.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 24 Jul 2021 18:49:43 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271560 Archived-At: > From: Lars Ingebrigtsen > Cc: emacs-devel@gnu.org > Date: Sat, 24 Jul 2021 18:49:43 +0200 > > Eli Zaretskii writes: > > > I actually don't understand the call to make_multibyte_string in that > > loop, either. Can you tell why you needed to convert unibyte strings? > > So that when constructing the final string all the elements have the > same(ish) multibytedness. Why not just require that up front? It makes no sense to append strings of different multibytedness to make a single file name from them. The only cases that make sense to me are: . all the strings are multibyte . some of the strings are multibyte, and some unibyte and pure-ASCII . all the strings are unibyte The last case can happen when we call this function very early during the startup process, before we set up the file-encoding stuff, and thus all the file names are unibyte strings.