From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 28bf387: Tweak Fdirectory_append for efficiency
Date: Sat, 24 Jul 2021 19:58:48 +0300 [thread overview]
Message-ID: <83sg03y7g7.fsf@gnu.org> (raw)
In-Reply-To: <87k0lf1wt4.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 24 Jul 2021 18:49:43 +0200)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Sat, 24 Jul 2021 18:49:43 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I actually don't understand the call to make_multibyte_string in that
> > loop, either. Can you tell why you needed to convert unibyte strings?
>
> So that when constructing the final string all the elements have the
> same(ish) multibytedness.
Why not just require that up front? It makes no sense to append
strings of different multibytedness to make a single file name from
them. The only cases that make sense to me are:
. all the strings are multibyte
. some of the strings are multibyte, and some unibyte and pure-ASCII
. all the strings are unibyte
The last case can happen when we call this function very early during
the startup process, before we set up the file-encoding stuff, and
thus all the file names are unibyte strings.
next prev parent reply other threads:[~2021-07-24 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 16:27 master 28bf387: Tweak Fdirectory_append for efficiency Eli Zaretskii
2021-07-24 16:29 ` Lars Ingebrigtsen
2021-07-24 16:36 ` Eli Zaretskii
2021-07-24 16:49 ` Lars Ingebrigtsen
2021-07-24 16:58 ` Eli Zaretskii [this message]
2021-07-24 17:05 ` Lars Ingebrigtsen
2021-07-24 17:13 ` Eli Zaretskii
2021-07-25 6:38 ` Lars Ingebrigtsen
2021-07-25 7:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sg03y7g7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).