From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Gitlab Migration Date: Sat, 28 Aug 2021 10:55:18 +0300 Message-ID: <83sfyungux.fsf@gnu.org> References: <87h7fcnmq0.fsf@posteo.net> <83tujbqg4j.fsf@gnu.org> <874kbbosht.fsf@gnus.org> <8335qur9h7.fsf@gnu.org> <831r6er6rz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, danflscr@gmail.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca, larsi@gnus.org, sir@cmpwn.com To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 28 09:56:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJtCD-0009gX-Sf for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Aug 2021 09:56:09 +0200 Original-Received: from localhost ([::1]:51862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJtCC-0002Jb-7o for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Aug 2021 03:56:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJtBg-0001c8-PM for emacs-devel@gnu.org; Sat, 28 Aug 2021 03:55:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56154) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJtBf-00077L-28; Sat, 28 Aug 2021 03:55:35 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3158 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJtBe-0002vl-JU; Sat, 28 Aug 2021 03:55:34 -0400 In-Reply-To: (message from Theodor Thornhill on Fri, 27 Aug 2021 23:04:55 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273243 Archived-At: > From: Theodor Thornhill > Cc: emacs-devel@gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca, > danflscr@gmail.com, philipk@posteo.net, sir@cmpwn.com > Date: Fri, 27 Aug 2021 23:04:55 +0200 > > ** Submitting patches by email. > It is possible to send patches using a web interface. It works by using > the `prepare a patchset` button on your own clone. So the process > is usually: > - clone the repo > - pull it locally > - do the work > - push the work > - use the `prepare a patchset` button or `git format-patch` Does it mean simply sending a patch via email is not supported? E.g., I could easily create a patch without a separate clone of the repository, using just the single clone I have already. You seem to describe something much more complicated, which starts with a separate clone? > ** Offline review > An issue (if not already subscribed to all) can be subscribed to your > own email and be sent to you. The whole thing or parts of it can be > downloaded as an mbox. Who gets automatically subscribed to an issue? > ** Reviewing by email > You can use inline comments [1] Do I just respond to an email with the patch, or do I have to use some special format for the inline comments? > ** Merge request creation > Honestly I don't really understand this one... It's about being able to submit a PR via email. > * Code should be accompanied by documentation > > This seems trivial, and can be done using the CI on patch submission > running a job, if I understand that point correctly? > > * Formatting code commits > Same as above FWIW, I very much doubt these two could be automated, except for very simple and almost trivial requirements. How can a bot decide whether a change requires documentation changes, and if so, which ones? Even our formatting of log messages is informal enough to defeat automation. This has to be part of patch review by humans. > * Bug reporting > `report-emacs-bug` can still be used, as well as clicking in the web > ui. This is where I'm not sure about not using email. I think you still > need to mail the bug, opened by a mailto: That's be a disadvantage in my book. > I hope this helps a little. It does, thanks a lot!