From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Splitting image-dired.el into smaller files Date: Thu, 09 Dec 2021 09:28:11 +0200 Message-ID: <83sfv2utis.fsf@gnu.org> References: <87o85q4mgx.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1209"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, stefan@marxist.se, mathias.dahl@gmail.com To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 09 08:31:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvDtV-00008l-7R for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 08:31:09 +0100 Original-Received: from localhost ([::1]:59184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvDtU-0001Qo-8T for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Dec 2021 02:31:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvDqw-0007eI-LM for emacs-devel@gnu.org; Thu, 09 Dec 2021 02:28:30 -0500 Original-Received: from [2001:470:142:3::e] (port=33006 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvDqu-0000AM-Hm; Thu, 09 Dec 2021 02:28:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=meTUgO69X6Pgl/Aw/EGQdmt51Dh+7rPqnIlcnmNaJ+8=; b=CMHYUMiuyxcK Iow2PrjL4MnUWRNpLVLw6AcRPSslIBqxHugswgEHpLAV+eghlx05m1NH5BQxVIAz/OQM/d5OLkL+O BKCl56v+nLyJkovRBozHU4mjEX2aJM+8wZoNx2El6C6V9jabGvXY4dXEkk16+/8TkFsaVCgHdgd8X N5HOH1DOeImN1DkiiQiaRT7a4VF3PeijJFLuldY/vOoEC7qzP1L9WprON8AXcn+Fzesa1ADXGAI2o yJDEpuBt+4UVwaDeiEZopCsxwn21o4YJ5McLPvQyR4AIfpANw5vwVCXbMWhEDAlU/rug2tBaYioLI kZ9VM4lBTU+31IGQA9MlLA==; Original-Received: from [87.69.77.57] (port=1424 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvDqt-0005hA-Ic; Thu, 09 Dec 2021 02:28:28 -0500 In-Reply-To: <87o85q4mgx.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 09 Dec 2021 02:05:02 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281451 Archived-At: > From: Lars Ingebrigtsen > Date: Thu, 09 Dec 2021 02:05:02 +0100 > Cc: Mathias Dahl , emacs-devel@gnu.org > > Stefan Kangas writes: > > > My current best idea for improving its organization is to split it up in > > several files along these lines: > > > > image/image-dired-bookmarks.el ;; bookmark.el support > > image/image-dired-compat.el ;; compatibility layer > > image/image-dired-gallery.el ;; HTML gallery generation > > image/image-dired-tags.el ;; home-cooked image tags > > image/image-dired-thumbs.el ;; thumbnail generation > > image/image-dired.el > > > > The big drawback here is that we will lose the git history. However, we > > lost most of that already in 2007 when the file was renamed. From my > > work and what I've seen so far, I don't think I will miss any history > > that won't be massively outweighed by the benefits of better code > > organization. > > I think sounds like a good reorganisation, and image-dired could use > some of that. (And like Stefan M said, the bookmark stuff seems small > enough to just keep in image-dired.el.) If you are going to split the file into several ones, please consider putting them in their own directory.