From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 28.0.90 is out Date: Sat, 11 Dec 2021 10:08:51 +0200 Message-ID: <83sfuzr2b0.fsf@gnu.org> References: <838rwuukkx.fsf@gnu.org> <878rwuavr7.fsf@yahoo.com> <831r2mug6n.fsf@gnu.org> <83zgpat0di.fsf@gnu.org> <87v8zy9c4o.fsf@yahoo.com> <87r1am9bsz.fsf@yahoo.com> <83wnkesz7r.fsf@gnu.org> <87mtl9apcx.fsf@yahoo.com> <83v8zxucaz.fsf@gnu.org> <87ilvxao13.fsf@yahoo.com> <83r1alub0m.fsf@gnu.org> <83pmq5ua9p.fsf@gnu.org> <83o85pu9u0.fsf@gnu.org> <83mtl9u9c8.fsf@gnu.org> <87a6h99uk5.fsf@yahoo.com> <875yrx9tlo.fsf@yahoo.com> <831r2kua9o.fsf@gnu.org> <877dcc6bw7.fsf@yahoo.com> <87wnkc4lrj.fsf@yahoo.com> <83lf0ssfho.fsf@gnu.org> <87o85o3q7h.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19461"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 11 09:11:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mvxTD-0004oC-Cu for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Dec 2021 09:11:03 +0100 Original-Received: from localhost ([::1]:40856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvxTB-0000BY-Ou for ged-emacs-devel@m.gmane-mx.org; Sat, 11 Dec 2021 03:11:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvxRG-0007tJ-GZ for emacs-devel@gnu.org; Sat, 11 Dec 2021 03:09:02 -0500 Original-Received: from [2001:470:142:3::e] (port=49158 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvxRG-0004E4-7d; Sat, 11 Dec 2021 03:09:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GqLSi7Sa3evcr6qj4hiR2Fvz7BzXUbRbsTPKJRSLUHo=; b=WlcT+rI7fJjv dhg4MY5c6v0XXM1SdldtcqBbDOXt4VPSQ6Vq6Ug512lfJWv1DoIlTuk7wd1prFCURqXSgjKJzCwb2 b1MM2YPWvNk2nWA77ukxSXAg/KuyRI7NqLuqQG8Yj6xEq8cheS1cKyuRbqcnAFhlzgTNDNF4guNLd 1qJY/6uztysRwi2paMNdAJBUf9tK/u26cpwXq5wVMzezfawU3Ph2+vpVwrMbV/EcaR8RAisBtwFoj 5bOy7qqJEKiWlnyQNGk58G5ojpefhSyoVWVR0UpQYbwkQmmWB5ClYffLUhYPNL1LmLsG3orX7YOK8 hkSEGCo47JktIQ+oS8q83w==; Original-Received: from [87.69.77.57] (port=1773 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvxRG-0000Pu-1R; Sat, 11 Dec 2021 03:09:02 -0500 In-Reply-To: <87o85o3q7h.fsf@yahoo.com> (message from Po Lu on Sat, 11 Dec 2021 09:06:26 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:281658 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Sat, 11 Dec 2021 09:06:26 +0800 > > >> +ifneq ($(MSDOS_OBJ),) > >> +temacs$(EXEEXT): $(LIBXMENU) $(ALLOBJS) $(LIBEGNU_ARCHIVE) $(EMACSRES) \ > >> + $(charsets) $(charscript) ${emoji-zwj} $(MAKE_PDUMPER_FINGERPRINT) > >> + $(AM_V_CCLD)$(CC) -o $@ \ > >> + $(ALL_CFLAGS) $(TEMACS_LDFLAGS) $(LDFLAGS) \ > >> + $(ALLOBJS) $(LIBEGNU_ARCHIVE) $(W32_RES_LINK) $(LIBES) > >> + $(MKDIR_P) $(etc) > >> +else > >> ## We have to create $(etc) here because init_cmdargs tests its > >> ## existence when setting Vinstallation_directory (FIXME?). > >> ## This goes on to affect various things, and the emacs binary fails > > > Couldn't you use the original recipe by a trivial editing (it seems > > all you need is to replace $@.tmp with $@?), instead of adding an > > ifdef? Come to think of that, why not use the original recipe without > > any changes, as it moves $@.tmp to $@ after the link succeeds? > > The linker apparently doesn't output a "stub" if the filename it's > assembling to doesn't end with ".exe", resulting in an invalid binary. That can be remedied by an explicit "stubify foo" command. I believe there are examples of that already in src/Makefile. Or you could call the temporary file $@-tmp instead of $@.tmp, so that it has no extension. And in any case, even if you want not to go through a temporary file, I'd prefer to edit the original recipe in sed1v2.inp instead of adding a DOS-specific recipe, as the former is safer for changes on the release branch.