unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: emacs-devel@gnu.org
Subject: so-long-mode and line-move-visual
Date: Sun, 08 May 2022 08:44:58 +0300	[thread overview]
Message-ID: <83sfpkwpb9.fsf@gnu.org> (raw)

Phil,

so-long.el has this passage:

 (defcustom so-long-variable-overrides
   '((bidi-inhibit-bpa . t)
     (bidi-paragraph-direction . left-to-right)
     (buffer-read-only . t)
     (global-hl-line-mode . nil)
     (line-move-visual . t)
     (show-paren-mode . nil)
     (truncate-lines . nil)
     (which-func-mode . nil))
   "Variables to override, and the values to override them with.

 The variables are given buffer-local values.  By default this happens if
 `so-long-action' is set to either `so-long-mode' or `so-long-minor-mode'.

 If `so-long-revert' is subsequently invoked, then the variables are restored
 to their original states.

 The combination of `line-move-visual' (enabled) and `truncate-lines' (disabled)
 is important for maximising responsiveness when moving vertically within an
 extremely long line, as otherwise the full length of the line may need to be
 scanned to find the next position.

It looks to me that the last paragraph (and the overrides to go with
it) has it backwards: line-move-visual set to nil produces _better_
performance than a non-nil value, and if truncate-lines is turned on,
the boost is even larger.  the explanation why is that so is correct,
but it describes the situation that's the opposite of the settings we
recommend.  I wonder why and how we came to the conclusion recorded in
the current code and the doc string.

Or what am I missing?



             reply	other threads:[~2022-05-08  5:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08  5:44 Eli Zaretskii [this message]
2022-05-08 10:02 ` so-long-mode and line-move-visual Phil Sainty
2022-05-08 11:20   ` Eli Zaretskii
2022-05-08 12:24     ` Phil Sainty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfpkwpb9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).