Re: Reworking loaddefs.el generation

[Eli Zaretskii <eliz@gnu.org>]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Wed, 01 Jun 2022 14:13:21 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I see this with the current master:
> >
> >   $ touch lisp/array.el .git/logs/HEAD
> >   $ make -j4
> >   [...]
> >     GEN      loaddefs.el
> >     INFO     Scraping files for loaddefs...
> >     INFO     Scraping files for loaddefs...26%
> >     INFO     Scraping files for loaddefs...53%
> >     INFO     Scraping files for loaddefs...81%
> >     INFO     Scraping files for loaddefs...done
> >     GEN      loaddefs.el
> >
> > Why so much "scraping" lines for just one file modified?
> 
> I get
> 
>   GEN      loaddefs.el
>   INFO     Scraping files for loaddefs... 
>   INFO     Scraping files for loaddefs...done
>   GEN      loaddefs.el
> 
> in that test case.
> 
> The loop is:
> 
>       (dolist (file files)
>         (progress-reporter-update progress (setq file-count (1+ file-count)))
>         (when (or (not updating)
>                   (file-newer-than-file-p file output-file))
>           <scrape>
> 
> So it seems like file-newer-than-file-p is very slow on your machine
> since progress-reporter manages to output several percentages?

However slow file-newer-than-file-p is here, it didn't become slower
since these changes were done.  Before those changes, I was used to
see the same as you see now: just two lines with no percents.  So
something did change that made the process slower, at least on this
machine.