From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Docstring hack Date: Sun, 31 Jul 2022 09:27:35 +0300 Message-ID: <83sfmh4x0o.fsf@gnu.org> References: <83bkt6687a.fsf@gnu.org> <871qu2lo29.fsf@yahoo.com> <837d3u63ez.fsf@gnu.org> <834jyy61w6.fsf@gnu.org> <831qu25z5x.fsf@gnu.org> <87mtcqhvot.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: owinebar@gmail.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 31 08:29:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oI2S7-000AOL-2e for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 08:29:27 +0200 Original-Received: from localhost ([::1]:55306 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oI2S5-0000eS-Gx for ged-emacs-devel@m.gmane-mx.org; Sun, 31 Jul 2022 02:29:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI2QY-0008Nd-BB for emacs-devel@gnu.org; Sun, 31 Jul 2022 02:27:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI2QX-00085T-Sg; Sun, 31 Jul 2022 02:27:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6mUDv8BK92gCnGaBtfJflvWoe0cNYZ2DZLFbMFR5ipI=; b=VqHxOnh4IiJ6 V2/3KD5qEd16OrHLlbUMvqL1kvF+seFr8bihoEEUB9FKyp+kuyqfPeSfPfyDvypfBtvYC5aFLlKuR npjHlkoCfiKqC2UwGVL6Jj5gnoG0oTc/6tIKUDXhKz9yTwX5dBPTSwapW99PCZGNbKw8AXHVGw2t4 CSZPubUTMS9dyGrMlQTh6WiAJcyFG+vvSTQFOJtyOho+2QFAY+7+VeKyL7A5vzvVeixBonRjcLmsn cP4T/HGFou5Swe8EJ8UjoPvSedyi44+Q5bYyRQ7YPXvo7g3MYLRon52Hv3eCij0itO1S/a6zbqI58 i6Coiw+t8tqfSu/xHmKjww==; Original-Received: from [87.69.77.57] (port=4093 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI2QW-0000SJ-TZ; Sun, 31 Jul 2022 02:27:49 -0400 In-Reply-To: <87mtcqhvot.fsf@yahoo.com> (message from Po Lu on Sun, 31 Jul 2022 10:17:54 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292893 Archived-At: > From: Po Lu > Cc: Lynn Winebarger , emacs-devel@gnu.org > Date: Sun, 31 Jul 2022 10:17:54 +0800 > > Eli Zaretskii writes: > > > TBH I don't really understand your 5 alternatives, because you are > > alluding to symbols I cannot find in the sources: I see neither > > read_literal_string nor dynamic-docstring. Are those typos or am I > > blind? > > I think he means read_string_literal and > byte-compile-dynamic-docstrings. OK, but I still lack some glue to understand the issue. Specifically: . the OP said "strings that are erroneously treated as docstrings in dump mode" -- where's the code which makes that mistake, and how is read_literal_string related to that mistake? . why isn't there an alternative to fix read_literal_string not to generate zero instead of the format template? the other alternatives all look like partial kludges to me