From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs master + org Wrong type argument: number-or-marker-p Date: Mon, 01 Aug 2022 20:59:41 +0300 Message-ID: <83sfmf26b6.fsf@gnu.org> References: <83bkt42ifq.fsf@gnu.org> <87a68ovw0b.fsf@posteo.net> <835yjc2c6f.fsf@gnu.org> <8335eg2ao9.fsf@gnu.org> <875yjbexde.fsf@posteo.net> <83zggn2a0c.fsf@gnu.org> <03AF0800-5252-429C-86BC-85DF9DF449F9@acm.org> <83tu6v27yh.fsf@gnu.org> <6F871C02-AC26-4B89-B64B-E9F4ACACDBE7@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31500"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, gregory@heytings.org, silent2600@gmail.com, emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 01 20:02:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIZkh-00080L-TU for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Aug 2022 20:02:52 +0200 Original-Received: from localhost ([::1]:33998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIZkg-0000Vd-Si for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Aug 2022 14:02:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIZhp-0007KD-7U for emacs-devel@gnu.org; Mon, 01 Aug 2022 13:59:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIZho-00062v-PK; Mon, 01 Aug 2022 13:59:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=+Qa60ecerJbW/P2rGNz/rUaJw3flBEu9xeYparbiM70=; b=r7DoAiTuDM1QoIogIqYl oLTtj6l6lpByh9w5KtnYxiOzZYEB5d6Vjv9VN1k9500bwDGBZEI5dJEvGrqviSm3SV1xoVuMiwe+Q gWXbTCH37ok7J9hKv8ZMfstqozID8ZwM9j7DAH559YQDfYvUpQ+fwziOXz2XbEEHO3VAGTvx9beWB Ya/qUqqSh3ThNHrJ6k8hOXZiehqkR58U+JMFIwOpPJu/W1hl8zoBoO+ehew9J5eoF2BIRVVoEXvbZ m1WI9dR3HTkFegXCTnDI6NInW7qkqd/hcCKI5J2uDGgKpxTr1t0aaR+80oos4zfsKsLT//34391tn jSEiUqBs/MNukA==; Original-Received: from [87.69.77.57] (port=4181 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIZho-0000q3-71; Mon, 01 Aug 2022 13:59:52 -0400 In-Reply-To: <6F871C02-AC26-4B89-B64B-E9F4ACACDBE7@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 1 Aug 2022 19:36:56 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292958 Archived-At: > From: Mattias EngdegÄrd > Date: Mon, 1 Aug 2022 19:36:56 +0200 > Cc: philipk@posteo.net, gregory@heytings.org, silent2600@gmail.com, > emacs-devel@gnu.org > > Frankly I'd recommend that the whole change be reverted because it performs unbalanced specbinds which we expect functions not to do. I don't think it can be salvaged in its current form; better back it out and let the author submit a new proposal for how to handle the problem. OK, thanks. Gregory, we don't really need to be able to make such "locked" narrowing from Lisp, do we? If we don't, my suggestion is to make a 3-arg C function whose guts is the current code of Fnarrow_to_region, and then have Fnarrow_to_region call that with the last argument nil. Then the changes in the byte compiler, byte-interpreter, and native-compiler can be reverted. If we do need to have a 3-arg version exposed to Lisp, a separate DEFUN is probably the best alternative.