From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Date: Wed, 08 Mar 2023 16:04:03 +0200 Message-ID: <83sfef49ws.fsf@gnu.org> References: <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org> <20230307172816.2D56BC13915@vcs2.savannah.gnu.org> <877cvsozn5.fsf@yahoo.com> <87zg8onfob.fsf@yahoo.com> <87ilfbpm0d.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14868"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ulm@gentoo.org, luangruo@yahoo.com, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 08 15:05:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZuPh-0003gJ-3E for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Mar 2023 15:05:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZuOm-000081-GI; Wed, 08 Mar 2023 09:04:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZuOk-00005x-Os for emacs-devel@gnu.org; Wed, 08 Mar 2023 09:04:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZuOj-00060h-9S; Wed, 08 Mar 2023 09:04:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=y5KAyGEuc1z76O1qNVx8f7OCINqtvLZWaqqUQQyyhwk=; b=K/EBYorMrxZJ74aprVMF a5LNO7Cue4yRP1Bqqa6unShbSgAAzqWYa1qd3BFfMqsOqHouNVOi7nxqSl4nHSOlKHgyjUDhLVDaJ Ac68ToHQQOsRsarj4hEXGLj2hq9K3+qL0GxVWj7UItH6H/ztMc1KNUBUXST1t5Bm6Yw8vewEdifzJ zaTep53lV1jELCApE4C3Z5VKnL43y62PgAfo6Eu1DdsUS8Yfc6h5+mFS5cigNP6CxjK1D4HCGGsEU OsRmIL1ZY1DtcRgX4VD4RlT3lyrqDm3blDGBD7zQC4D/EuCTErNF8a9hT2ejUFXb9LJ/TXaSBatxf ax2hlfPGd0fQXg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZuOi-0007rE-Jf; Wed, 08 Mar 2023 09:04:04 -0500 In-Reply-To: <87ilfbpm0d.fsf@gmail.com> (message from Robert Pluim on Wed, 08 Mar 2023 11:37:06 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304131 Archived-At: > From: Robert Pluim > Cc: Po Lu , emacs-devel@gnu.org > Date: Wed, 08 Mar 2023 11:37:06 +0100 > > Itʼs certainly not a regression, but it is fairly serious. We could > mitigate it somewhat by adding '--funcall', I guess. > > The last time --funcall was discussed, there was no consensus on how > arguments should be handled, so Iʼve just gone ahead and implemented > one variant. We could add any restrictions we like on the server side, > it currently just disallows direct `eval' > > Not for emacs-29, I think. Indeed, not for emacs-29. So if requiring Bash is not going to fly, we need to find a different way to fix the original problem. Adding a general-purpose command-line option to emacsclient, which also requires a change in the client-server protocol, is out of the question for emacs-29.