From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dict Date: Thu, 18 May 2023 17:09:23 +0300 Message-ID: <83sfbtvii4.fsf@gnu.org> References: <834joj55pt.fsf@gnu.org> <87ednnvtt6.fsf@posteo.net> <875y8ywwko.fsf@posteo.net> <83zg69br5f.fsf@gnu.org> <83ednj9sw2.fsf@gnu.org> <837ct5x5v6.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22628"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 18 16:09:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzeKM-0005fn-7l for ged-emacs-devel@m.gmane-mx.org; Thu, 18 May 2023 16:09:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzeJd-0005dK-Oi; Thu, 18 May 2023 10:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzeJd-0005d7-0x for emacs-devel@gnu.org; Thu, 18 May 2023 10:09:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzeJc-0004f8-4h; Thu, 18 May 2023 10:09:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mDlbKkiEwlZD54PGu4xfl+NdRRF0JGcG6l/hDJ1vX10=; b=WieJNyFgsJyq CJ79/VNQRKyX1vuVx8AccaIA2OPSJlQy9hkCyUrcwTuiEwYUXLKCaWIU+D1oW3+7uAH/Y3qN1WK2e 0pci8IoxKBh318xVFAlb3xryOh25CUsup7NUNyQbLQFlvHBPGsVqiD9Gb1kaxfyaRIO68AnlwfvcH 7EpySpIWYbk6Y09BzslL5DFFMKCWw++XDcpyUKBgm0I/Y7GhkTmfwZJebTpStQJmtjiybtxC2wyQK 3ARMYFUbwYYQfkP1lYi+hu2nNr500qG8MCNiqFm/gzCJ2awRQFiktbSmFFOV9fV297r8k2a1ZITEM I/ZxanicClxIepG9WCpdCw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzeJb-0001V1-Jz; Thu, 18 May 2023 10:09:11 -0400 In-Reply-To: (message from Eshel Yaron on Thu, 18 May 2023 15:21:31 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306175 Archived-At: > From: Eshel Yaron > Cc: philipk@posteo.net, emacs-devel@gnu.org > Date: Thu, 18 May 2023 15:21:31 +0300 > > Eli Zaretskii writes: > > >> --8<---------------cut here---------------start------------->8--- > >> (setq dictionary-read-dictionary-function > >> #'dictionary-completing-read-dictionary) > >> (setq dictionary-read-word-function > >> #'dictionary-completing-read-word) > >> (setq dictionary-display-definition-function > >> #'dictionary-display-definition-in-help-buffer) > >> --8<---------------cut here---------------end--------------->8--- > > > > This looks excessive. How about adding yet another defcustom, with a > > :set function, which will make all these adjustments for users who > > want the words displayed in *Help*? > > I agree setting three options may be a bit much for casual users, but > note that in order to display word definitions in *Help* you only need > to customize the last option, `dictionary-display-definition-function`. > The other two only affect the interactive word and dictionary selection > (mostly adding completion), so I'm not sure it's necessary to couple > them with how the definition ends up being presented. Then why did you add the other options?