unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: visuweshm@gmail.com, h.judt@gmx.at, emacs-devel@gnu.org
Subject: Re: [ELPA] New package: dired-duplicates
Date: Wed, 01 Nov 2023 21:24:35 +0200	[thread overview]
Message-ID: <83sf5p8efg.fsf@gnu.org> (raw)
In-Reply-To: <87lebhz78r.fsf@posteo.net> (message from Philip Kaludercic on Wed, 01 Nov 2023 17:57:40 +0000)

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: Visuwesh <visuweshm@gmail.com>,  h.judt@gmx.at,  emacs-devel@gnu.org
> Date: Wed, 01 Nov 2023 17:57:40 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I'd like to see the numbers which led to the conclusion that
> > performance was prohibitive.
> >
> > And even if the performance is indeed much worse, it could be a
> > fallback in case the program is not available -- which would IMO be
> > much better than simply failing to provide the functionality in that
> > case.
> 
> This is a cheap test on a 1.4GB ISO I had lying around:

Thanks.  But this is just a single large file, not a frequent use case
for this package.

> --8<---------------cut here---------------start------------->8---
> (benchmark-run 1
>   (with-temp-buffer
>     (insert-file-contents-literally "~/Downloads/haiku-r1beta4-x86_64-anyboot.iso")
>     (secure-hash 'sha512 (current-buffer))))
> ;; (44.389091035 1 1.5836082630000021)
> 
> (benchmark-run 1
>   (with-temp-buffer
>     (call-process "sha512sum" nil t nil (expand-file-name "~/Downloads/haiku-r1beta4-x86_64-anyboot.iso"))
>     (goto-char (point-min))
>     (and (looking-at (rx bos (+ alnum)))
> 	 (match-string 0))))
> ;; (5.155846791 0 0.0)
> --8<---------------cut here---------------end--------------->8---

And this is not the package doing its job, this is just a single task
the package does when looking for duplicates.  The numbers when
running the package with call-process replaced by secure-hash will
probably be different.



  reply	other threads:[~2023-11-01 19:24 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 10:34 [ELPA] New package: dired-duplicates Harald Judt
2023-10-31 12:21 ` Philip Kaludercic
2023-10-31 21:05   ` Harald Judt
2023-11-01  2:14     ` Michael Heerdegen
2023-11-01 15:16       ` [External] : " Drew Adams
2023-11-01 15:45         ` Eli Zaretskii
2023-11-01 16:28           ` Drew Adams
2023-11-01 16:47             ` Eli Zaretskii
2023-11-01 16:33         ` Philip Kaludercic
2023-11-01 11:32     ` Philip Kaludercic
2023-11-01 20:04       ` Harald Judt
2023-11-01 21:29         ` Philip Kaludercic
2023-11-02  8:44           ` Harald Judt
2023-11-03  8:19             ` Philip Kaludercic
2023-11-03 20:19               ` Harald Judt
2023-11-04 15:27                 ` Philip Kaludercic
2023-11-06  9:33                   ` Harald Judt
2023-11-10  8:37                     ` Philip Kaludercic
2023-11-10 10:02                       ` Harald Judt
2023-11-23  6:12                         ` Philip Kaludercic
2023-10-31 21:24   ` Harald Judt
2023-11-01 17:40     ` Stefan Kangas
2023-11-01  3:30   ` Eli Zaretskii
2023-11-01 13:53     ` Visuwesh
2023-11-01 14:12       ` Eli Zaretskii
2023-11-01 17:57         ` Philip Kaludercic
2023-11-01 19:24           ` Eli Zaretskii [this message]
2023-11-01 20:09             ` Harald Judt
2023-11-02  5:55               ` Eli Zaretskii
2023-11-08 20:29                 ` Harald Judt
2023-11-09  5:52                   ` Eli Zaretskii
2023-11-09  8:00                     ` Harald Judt
2023-11-09  8:38                       ` tomas
2023-11-09  8:48                         ` Eli Zaretskii
2023-11-09  8:43                       ` Eli Zaretskii
2023-11-09  8:53                         ` tomas
2023-11-09  9:18                         ` Harald Judt
2023-11-09 14:52                           ` Harald Judt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sf5p8efg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=h.judt@gmx.at \
    --cc=philipk@posteo.net \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).