From: Eli Zaretskii <eliz@gnu.org>
To: Toru TSUNEYOSHI <t_tuneyosi@hotmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: macro FIXNUM_OVERFLOW_P in lisp.h is valid ?
Date: Sat, 24 Oct 2009 12:11:01 +0200 [thread overview]
Message-ID: <83r5stf6fe.fsf@gnu.org> (raw)
In-Reply-To: <BLU0-SMTP5996308C0C516ADD2A6AFE2BC0@phx.gbl>
> Date: Sat, 24 Oct 2009 16:46:55 +0900
> Cc: emacs-devel@gnu.org
> From: Toru TSUNEYOSHI <t_tuneyosi@hotmail.com>
>
> >> So in 64-bit platforms, casting `double' to `int' causes lack of
> >> precision already (because a double does not have 64 bits in the
> >> mantissa), doesn't it?
> >
> > So I make a patch for keep the precision.
> > It tries to deal with the number in type `int' possibly, otherwise it
> > deals with the number in type `double'.
> >
> > Would you like to check it ?
>
> I revised the patch.
I think we should fix the make_fixnum_or_float macro, rather than work
around it in C code.
> +#ifdef _LP64
> + if (v > LONG_MAX / b)
This will probably not portable enough, e.g. on 64-bit Windows. We
have MOST_POSITIVE_FIXNUM precisely for that reason.
next prev parent reply other threads:[~2009-10-24 10:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 17:51 macro FIXNUM_OVERFLOW_P in lisp.h is valid ? Toru TSUNEYOSHI
2009-10-23 19:33 ` Eli Zaretskii
2009-10-24 1:50 ` Toru TSUNEYOSHI
2009-10-24 9:05 ` Eli Zaretskii
2009-10-24 11:59 ` Toru TSUNEYOSHI
2009-10-24 13:00 ` Eli Zaretskii
2009-10-24 18:45 ` Toru TSUNEYOSHI
2009-10-24 15:14 ` Andreas Schwab
2009-10-24 18:39 ` Stefan Monnier
2009-10-26 14:48 ` Toru TSUNEYOSHI
[not found] ` <20091024.105033.100383844.t_tuneyosi@hotmail.com>
2009-10-24 6:07 ` Toru TSUNEYOSHI
[not found] ` <20091024.150744.186061320.t_tuneyosi@hotmail.com>
2009-10-24 7:46 ` Toru TSUNEYOSHI
2009-10-24 10:11 ` Eli Zaretskii [this message]
2009-10-23 20:57 ` Andreas Schwab
2009-10-23 22:02 ` Eli Zaretskii
2009-10-24 1:05 ` Stefan Monnier
2009-10-24 9:15 ` Eli Zaretskii
2009-10-24 9:40 ` Andreas Schwab
2009-10-24 10:16 ` Eli Zaretskii
2009-10-24 10:01 ` Andreas Schwab
2009-10-23 21:14 ` Stefan Monnier
2009-10-25 8:51 ` Toru TSUNEYOSHI
[not found] ` <20091025.175131.55657724.t_tuneyosi@hotmail.com>
2009-10-25 11:30 ` Toru TSUNEYOSHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r5stf6fe.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=t_tuneyosi@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).