From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: new file tparam.h to fix Emacs API glitch Date: Sat, 12 Mar 2011 14:11:40 +0200 Message-ID: <83r5acsflv.fsf@gnu.org> References: <4D767635.5070700@cs.ucla.edu> <4D767E6C.7080000@cs.ucla.edu> <8339mxh0jn.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1299932080 1998 80.91.229.12 (12 Mar 2011 12:14:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2011 12:14:40 +0000 (UTC) To: eggert@cs.ucla.edu, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 13:14:36 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PyNiN-000152-Jf for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2011 13:14:35 +0100 Original-Received: from localhost ([127.0.0.1]:59887 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PyNiB-0006RX-Qh for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2011 07:14:23 -0500 Original-Received: from [140.186.70.92] (port=47449 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PyNi5-0004wY-08 for emacs-devel@gnu.org; Sat, 12 Mar 2011 07:14:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PyNfW-0005B6-DS for emacs-devel@gnu.org; Sat, 12 Mar 2011 07:11:39 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:57502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PyNfW-0005Av-4w for emacs-devel@gnu.org; Sat, 12 Mar 2011 07:11:38 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LHY001001HOT400@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 12 Mar 2011 14:11:36 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.124.58.59]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHY0019U1VBMZ40@a-mtaout20.012.net.il>; Sat, 12 Mar 2011 14:11:36 +0200 (IST) In-reply-to: <8339mxh0jn.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137148 Archived-At: > Date: Tue, 08 Mar 2011 21:31:08 +0200 > From: Eli Zaretskii > Cc: emacs-devel@gnu.org > > > Date: Tue, 08 Mar 2011 11:07:24 -0800 > > From: Paul Eggert > > > > Following up on my previous message, termcap.c implements > > part of the interface described in the new tparam.h, so it > > should include it. > > termcap.c is compiled only by the MS-DOS build. No other build, > including the MS-Windows build and all Posix platforms, uses it. So I > don't think you need to make any changes in it. Let's just leave it > alone. I eventually did include tparam.h in termcap.c and modified termcap.c to match the prototypes. However, I made only the minimal changes necessary for the implementation to match the declarations. Since termcap.c is used only by the MSDOS build, I don't see a reason to maintain it beyond the absolute minimum. Thanks.