From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Hannu Koivisto Newsgroups: gmane.emacs.devel Subject: Re: A few Windows build fixes Date: Mon, 29 Aug 2011 11:18:33 +0300 Organization: NOYB Message-ID: <83r5444ome.fsf@kalahari.s2.org> References: <83vcth40ik.fsf@kalahari.s2.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1314605943 8801 80.91.229.12 (29 Aug 2011 08:19:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 29 Aug 2011 08:19:03 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 29 10:18:58 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qxx3Z-0001au-IE for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2011 10:18:57 +0200 Original-Received: from localhost ([::1]:52655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxx3Y-0002pn-L1 for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2011 04:18:56 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:54427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxx3W-0002pi-1L for emacs-devel@gnu.org; Mon, 29 Aug 2011 04:18:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qxx3U-0001o5-NJ for emacs-devel@gnu.org; Mon, 29 Aug 2011 04:18:54 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:55022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qxx3U-0001nj-B6 for emacs-devel@gnu.org; Mon, 29 Aug 2011 04:18:52 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qxx3S-0001a0-J4 for emacs-devel@gnu.org; Mon, 29 Aug 2011 10:18:50 +0200 Original-Received: from s2.org ([80.83.7.53]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 29 Aug 2011 10:18:50 +0200 Original-Received: from azure by s2.org with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 29 Aug 2011 10:18:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 119 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: s2.org User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.3 (gnu/linux) Cancel-Lock: sha1:nHYufpbwTkcjXrvVnA8gPb/Ad0I= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:143619 Archived-At: Eli Zaretskii writes: >> From: Hannu Koivisto >> Date: Mon, 29 Aug 2011 01:46:59 +0300 >> >> I wanted to build the latest bzr trunk version of Emacs for Windows >> but soon realized that the makefiles and the configure process have >> lots of problems. > > Only if you use Cygwin tools. With native (MinGW/GnuWin32) tools, > there are no known problems, AFAIK. I haven't heard of GnuWin32; looks like something similar to msys, which I feel is the "standard" set of tools to be used with mingw. In any case, it's my opinion that trying to support all these different environments with the same makefiles (assuming that something like cmake or similar, which is able to create real makefiles for native tools from a higher level description, is not used) only leads to trouble. >> +if %MAKECMD% == gmake dos2unix config.tmp config.settings > > This requires users to have dos2unix installed, even if they don't use > the Cygwin tools to build Emacs. If there's another way of doing this I recall I tested that failure to find dos2unix doesn't stop bat execution, but maybe I remember incorrectly. >> --- a/nt/makefile.w32-in >> +++ b/nt/makefile.w32-in > > Is there some real change here, or did you only change EOL format? If > the former, please show just the changes in content. EOL format plus removal of FIXME comment (which should be shown only if you disable showing whitespace differences in your diff inspecting tool of choice). >> Cygwin make doesn't like c:/foo/bar style paths at least in targets and >> native Windows Emacs doesn't like Cygwin style /cygdrive/c/foo/bar paths. >> Use relative paths to avoid the problem. > > It's true that the Cygwin build of Make doesn't support c:/foo in > targets, but the Windows Makefiles never use such targets, except > through $(CURDIR), which should return a Cygwin style file name with > Cygwin Make. So I don't really see a problem that needs to be solved > here. Perhaps I'm missing something; please show the actual problems > you had with this part. CURDIR-based paths are passed to native Emacs for load path purposes and if they have /cygdrive/ stuff in them, Emacs doesn't understand that. > In any case, I'd like to find a solution for this problem that targets > Cygwin alone, if possible. Sprinkling quotes in 2 different styles > all over the Makefiles is not my idea of fun, because the quoting > issue is very fragile on Windows to begin with, especially since we > try to support at least 3 or 4 different combinations of tools. At first I used macros DQUOTE etc. but gave up after seeing that normal double quotes were used in many, many places. >> +CURDIR=. > > This will break "make -C", won't it? Or at least make it fragile and > unreliable. Perhaps. Is there a need to use -C when building Emacs for Windows? A more important need than to build Emacs under Cygwin? >> - - mkdir "$(INSTALLDIR)" >> + - mkdir -p "$(INSTALLDIR)" > > Please don't. We don't want to rely on the assumption that `mkdir' is > a GNU mkdir.exe. This command needs also to run when the shell is > cmd.exe, and its built-in `mkdir' doesn't support the -p switch (it > creates intermediate directories by default). Using cmd didn't work with mingw/msys (make SHELL=cmd.exe didn't do anything at all) so I couldn't test that. Not that I would have considered supporting cmd as the shell (with GNU make makefiles, nmake is another matter) even if it had worked. > There are more places where you use "mkdir -p"; please find some other > solution for that particular problem, or let's leave it unsolved, as > no one has complained until now, AFAIR. Well, if mkdir in cmd works like "mkdir -p", I suppose one could simply use a macro and set it to either mkdir or mkdir -p depending on the shell being used. Not solving this means that "make install" won't work when cmd is not used. >> +INSTALL_DIR_MIXED := $(INSTALL_DIR) >> +ifeq "$(shell cygpath $(INSTALL_DIR))" "$(INSTALL_DIR)" >> +INSTALL_DIR_MIXED := $(shell cygpath -m "$(INSTALL_DIR)") >> +endif > > I don't understand the need for this gork. Please explain. Is the > Cygwin build supposed to use Cygwin `cp' etc., or their native > versions? > > In any case, why do we need both INSTALL_DIR and INSTALL_DIR_MIXED? When used in makefile rules, Cygwin style path is needed, and when passing the path to native binaries like addpm etc that are used during installation, a mixed style path is needed. `cp' and everything else is assumed to be a Cygwin version when building under Cygwin. > If both are needed, we will need a corresponding change in nmake.defs. I don't think changes are needed in nmake.defs, Cygwin style paths should not be involved there. -- Hannu