From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r116230: Fix bug #16558 with w32-shell-execute on remote file names. Date: Wed, 05 Feb 2014 05:56:03 +0200 Message-ID: <83r47i1acs.fsf@gnu.org> References: <83ob2q4nbv.fsf@gnu.org> <83k3de41sc.fsf@gnu.org> <83iosx4iid.fsf@gnu.org> <83txcg3fle.fsf@gnu.org> <83lhxs2mru.fsf@gnu.org> <837g9a3kmb.fsf@gnu.org> <83vbwu1tk2.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1391572578 21077 80.91.229.3 (5 Feb 2014 03:56:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Feb 2014 03:56:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 05 04:56:25 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WAtb6-0007ea-A5 for ged-emacs-devel@m.gmane.org; Wed, 05 Feb 2014 04:56:24 +0100 Original-Received: from localhost ([::1]:57283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAtb5-00079o-Vg for ged-emacs-devel@m.gmane.org; Tue, 04 Feb 2014 22:56:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAtay-00076L-D4 for emacs-devel@gnu.org; Tue, 04 Feb 2014 22:56:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAtat-0003YZ-6M for emacs-devel@gnu.org; Tue, 04 Feb 2014 22:56:16 -0500 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:55355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAtas-0003YR-Ui for emacs-devel@gnu.org; Tue, 04 Feb 2014 22:56:11 -0500 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0N0I00I006LZRK00@mtaout27.012.net.il> for emacs-devel@gnu.org; Wed, 05 Feb 2014 05:55:02 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N0I00KYO87QUA30@mtaout27.012.net.il>; Wed, 05 Feb 2014 05:55:02 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169404 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Tue, 04 Feb 2014 21:38:12 -0500 > > So I guess the best we can do is: > > (if (file-name-absolute-p file) > (let ((dir (file-name-directory file))) > (if (null dir) > (if (faccess dir) > )))) Yes, except that the primitives you use here only work on file names, and might go bananas when presented with something else, e.g. a URL. So using the above does not solve the basic problem, which is: do we have a file name on our hands or something else? The faccess test is the only thing that provides us with some assurance.