From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Copyright years update in etags test suite Date: Sat, 30 Jan 2016 20:25:52 +0200 Message-ID: <83r3gy53gv.fsf@gnu.org> References: <83mvrnwe0z.fsf@gnu.org> <56ACFE75.1080307@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1454178413 2219 80.91.229.3 (30 Jan 2016 18:26:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Jan 2016 18:26:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 30 19:26:39 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aPaEJ-0004MK-2M for ged-emacs-devel@m.gmane.org; Sat, 30 Jan 2016 19:26:39 +0100 Original-Received: from localhost ([::1]:39450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPaEH-0002ns-Sy for ged-emacs-devel@m.gmane.org; Sat, 30 Jan 2016 13:26:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPaE4-0002nm-SS for emacs-devel@gnu.org; Sat, 30 Jan 2016 13:26:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPaE1-000076-LP for emacs-devel@gnu.org; Sat, 30 Jan 2016 13:26:24 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPaE1-00006z-Ic; Sat, 30 Jan 2016 13:26:21 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2401 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aPaE0-00062G-Ok; Sat, 30 Jan 2016 13:26:21 -0500 In-reply-to: <56ACFE75.1080307@cs.ucla.edu> (message from Paul Eggert on Sat, 30 Jan 2016 10:18:29 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199052 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Sat, 30 Jan 2016 10:18:29 -0800 > > Eli Zaretskii wrote: > > I fixed this, but I wonder whether we really need to do these updates > > in the etags test suite. The source files there are not maintained in > > any way, so perhaps they could be skipped? > > Although I suppose skipping could be arranged in the procedure that updates > copyrights, this would be a change to copyright-notice policy which would > probably require going through channels and getting it approved. I understand. > > If we do have to update the Copyright there, then the annual update > > procedure should include the corresponding update to the > > expected-results files. > > How about another idea: fix tests so that they are robust in the presence of > changes to copyright notices. After all, tests are supposed to be testing > features, not copyrights. I don't know which tests were failing and why, so I > don't know how much work this would be. All of the etags tests failed, because the TAGS file records both line numbers and character positions of tags. The latter changed for tags from any test file that has an FSF Copyright notice; the former changed for tags from a few test files that inserted an extra line (because the Copyright notice became too long for a single line). Fixing the tests for such effects would mean somehow parsing the TAGS files, extracting the numbers, and correcting them for the inserted text, which sounds like a PITA for something that happens once a year. Is there an easier way?