unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Copyright years update in etags test suite
Date: Sat, 30 Jan 2016 20:25:52 +0200	[thread overview]
Message-ID: <83r3gy53gv.fsf@gnu.org> (raw)
In-Reply-To: <56ACFE75.1080307@cs.ucla.edu> (message from Paul Eggert on Sat,  30 Jan 2016 10:18:29 -0800)

> Cc: emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sat, 30 Jan 2016 10:18:29 -0800
> 
> Eli Zaretskii wrote:
> > I fixed this, but I wonder whether we really need to do these updates
> > in the etags test suite.  The source files there are not maintained in
> > any way, so perhaps they could be skipped?
> 
> Although I suppose skipping could be arranged in the procedure that updates 
> copyrights, this would be a change to copyright-notice policy which would 
> probably require going through channels and getting it approved.

I understand.

> > If we do have to update the Copyright there, then the annual update
> > procedure should include the corresponding update to the
> > expected-results files.
> 
> How about another idea: fix tests so that they are robust in the presence of 
> changes to copyright notices. After all, tests are supposed to be testing 
> features, not copyrights. I don't know which tests were failing and why, so I 
> don't know how much work this would be.

All of the etags tests failed, because the TAGS file records both line
numbers and character positions of tags.  The latter changed for tags
from any test file that has an FSF Copyright notice; the former
changed for tags from a few test files that inserted an extra line
(because the Copyright notice became too long for a single line).

Fixing the tests for such effects would mean somehow parsing the TAGS
files, extracting the numbers, and correcting them for the inserted
text, which sounds like a PITA for something that happens once a year.
Is there an easier way?



  reply	other threads:[~2016-01-30 18:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-30 10:35 Copyright years update in etags test suite Eli Zaretskii
2016-01-30 18:18 ` Paul Eggert
2016-01-30 18:25   ` Eli Zaretskii [this message]
2016-01-30 18:28     ` Paul Eggert
2016-01-30 18:29       ` Eli Zaretskii
2016-01-30 18:33         ` Paul Eggert
2016-01-30 18:40           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r3gy53gv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).