From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Build failure for Emacs master Date: Thu, 14 Apr 2016 19:19:54 +0300 Message-ID: <83r3e8duxh.fsf@gnu.org> References: <56CCD91E.6070507@alice.it> <83egc2ixji.fsf@gnu.org> <56CD798D.7060102@alice.it> <56CD8408.1000701@alice.it> <83wppuggb4.fsf@gnu.org> <56CE2CA7.5050906@alice.it> <83io1cg2pt.fsf@gnu.org> <56DA0327.2030009@alice.it> <83oaatxu72.fsf@gnu.org> <570C4307.6050907@alice.it> <83k2k2g82s.fsf@gnu.org> <86egaa7b0z.fsf@gmail.com> <83a8kyfd38.fsf@gnu.org> <86lh4hm7dd.fsf@gmail.com> <570FBFEB.90803@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1460650852 1293 80.91.229.3 (14 Apr 2016 16:20:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Apr 2016 16:20:52 +0000 (UTC) Cc: emacs-devel@gnu.org, andrewjmoreton@gmail.com, phillip.lord@russet.org.uk To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 14 18:20:51 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aqk0g-0006cw-IZ for ged-emacs-devel@m.gmane.org; Thu, 14 Apr 2016 18:20:50 +0200 Original-Received: from localhost ([::1]:42533 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqk0f-0005FE-VK for ged-emacs-devel@m.gmane.org; Thu, 14 Apr 2016 12:20:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqk0F-0005Cf-KV for emacs-devel@gnu.org; Thu, 14 Apr 2016 12:20:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqk0B-0002Zo-Kz for emacs-devel@gnu.org; Thu, 14 Apr 2016 12:20:23 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqk0B-0002Zk-I9; Thu, 14 Apr 2016 12:20:19 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1190 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aqk0A-0003LI-QK; Thu, 14 Apr 2016 12:20:19 -0400 In-reply-to: <570FBFEB.90803@cs.ucla.edu> (message from Paul Eggert on Thu, 14 Apr 2016 09:06:03 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202914 Archived-At: > From: Paul Eggert > Date: Thu, 14 Apr 2016 09:06:03 -0700 > Cc: emacs-devel@gnu.org > > I am suspicious of copy-file. Why does it copy files possibly in text > mode on MS-Windows No, we set the mode to be binary by default in emacs_open, if text isn't explicitly requested: int emacs_open (const char *file, int oflags, int mode) { int fd; if (! (oflags & O_TEXT)) oflags |= O_BINARY; <<<<<<<<<<<<<<<<<<<<<<<<< oflags |= O_CLOEXEC; while ((fd = open (file, oflags, mode)) < 0 && errno == EINTR) QUIT; (Emacs on Windows always used binary mode by default, it's just that we changed the implementation of that lately: instead of setting the global variable _fmode, we now conceal that in emacs_open.)