From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: block_input for some APIs
Date: Tue, 13 Dec 2016 05:46:47 +0200 [thread overview]
Message-ID: <83r35cbie0.fsf@gnu.org> (raw)
In-Reply-To: <r025y3zk3jc2.fsf@dancol.org> (message from Daniel Colascione on Mon, 12 Dec 2016 13:53:33 -0800)
> From: Daniel Colascione <dancol@dancol.org>
> Date: Mon, 12 Dec 2016 13:53:33 -0800
> Cc: emacs-devel@gnu.org
>
> That said, the existing calls to block_input don't do a lot of harm, so
> there's no need to remove them.
They make the code trickier to read and understand, because
block_input, unblock_input, and input_blocked_p are not thread-safe.
It took me a while to convince myself they are not an issue with the
current concurrency design, except in xgselect.c, and I'm still not
sure my conclusion is 100% valid.
next prev parent reply other threads:[~2016-12-13 3:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 18:01 block_input for some APIs Eli Zaretskii
2016-12-12 21:08 ` Paul Eggert
2016-12-12 21:48 ` Stefan Monnier
2016-12-12 21:53 ` Daniel Colascione
2016-12-13 3:46 ` Eli Zaretskii [this message]
2016-12-13 0:13 ` YAMAMOTO Mitsuharu
2016-12-13 3:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r35cbie0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).