From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Fri, 14 Apr 2017 10:27:08 +0300 Message-ID: <83r30vh2k3.fsf@gnu.org> References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> <83h91sizcn.fsf@gnu.org> <87vaq79903.fsf@localhost> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1492154847 7548 195.159.176.226 (14 Apr 2017 07:27:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Apr 2017 07:27:27 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 14 09:27:21 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyvdY-0001qK-Uc for ged-emacs-devel@m.gmane.org; Fri, 14 Apr 2017 09:27:21 +0200 Original-Received: from localhost ([::1]:52163 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyvde-0004UJ-Rj for ged-emacs-devel@m.gmane.org; Fri, 14 Apr 2017 03:27:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyvd2-0004U5-8a for emacs-devel@gnu.org; Fri, 14 Apr 2017 03:26:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyvcz-00049G-3P for emacs-devel@gnu.org; Fri, 14 Apr 2017 03:26:48 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyvcy-000492-VX; Fri, 14 Apr 2017 03:26:45 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1702 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cyvcy-0002Nm-6t; Fri, 14 Apr 2017 03:26:44 -0400 In-reply-to: <87vaq79903.fsf@localhost> (message from Juri Linkov on Fri, 14 Apr 2017 02:35:08 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213957 Archived-At: > From: Juri Linkov > Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org > Date: Fri, 14 Apr 2017 02:35:08 +0300 > > > Alas, a couple of users of kill-this-buffer were sometimes calling it > > in the context of a menu-invoked command, so that part still can make > > sense. And I have no idea which of the callers relied on this feature > > even when invoking the function via non-menu events. It's been 9 > > years since this feature was introduced. > > I'm sure that all these callers used kill-this-buffer because there was no > kill-current-buffer to simply kill the current buffer, and nothing more. I'm sure we have no idea whether we can be sure. After so many years that this code existed, I see no reason to rock the boat now. This bike shed's color was fixed long ago; if we didn't care during all these years, we should definitely leave it at that now. All I did was to add a simple sentence to the doc string, something that was over the years requested a couple of times, with no-one bothering to do anything, not even reply. And look what tempest did this small change cause! I wonder why. > So I think we need to leave kill-this-buffer callers only in menu-bar/tool-bar, > and use kill-current-buffer everywhere else, leaving just > ‘(kill-buffer (current-buffer))’ in the definition of > kill-current-buffer in simple.el. Sorry, I disagree.