From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: michael.albinus@gmx.de, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it.
Date: Mon, 24 Jul 2017 20:01:14 +0300 [thread overview]
Message-ID: <83r2x57orp.fsf@gnu.org> (raw)
In-Reply-To: <hgeft5zsai.fsf@fencepost.gnu.org> (message from Glenn Morris on Mon, 24 Jul 2017 12:57:41 -0400)
> From: Glenn Morris <rgm@gnu.org>
> Date: Mon, 24 Jul 2017 12:57:41 -0400
> Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>, emacs-devel@gnu.org
>
> --- i/lisp/display-line-numbers.el
> +++ w/lisp/display-line-numbers.el
> @@ -38,7 +38,6 @@ display-line-numbers
> "Display line numbers in the buffer."
> :group 'display)
>
> -;;;###autoload
> (defcustom display-line-numbers-type t
> "The default type of line numbers to use in `display-line-numbers-mode'.
> See `display-line-numbers' for value options."
> diff --git i/lisp/menu-bar.el w/lisp/menu-bar.el
> index 05a336b..e02217f 100644
> --- i/lisp/menu-bar.el
> +++ w/lisp/menu-bar.el
> @@ -1101,6 +1101,9 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom
> :button (:radio . (eq tool-bar-mode nil))))
> menu)))
>
> +;; Following function calls will autoload the library.
> +(defvar display-line-numbers-type)
> +
> (defun menu-bar-display-line-numbers-mode (type)
> (setq display-line-numbers-type type)
> (if global-display-line-numbers-mode
How is this better than the autoload? At least the autoload doesn't
need a comment to explain why it is there.
next prev parent reply other threads:[~2017-07-24 17:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170723072843.23485.53761@vcs0.savannah.gnu.org>
[not found] ` <20170723072844.877FD22EF0@vcs0.savannah.gnu.org>
2017-07-23 13:28 ` [Emacs-diffs] master 012487b: * lisp/display-line-numbers.el (display-line-numbers-type): Autoload it Stefan Monnier
2017-07-23 14:02 ` Michael Albinus
2017-07-24 16:57 ` Glenn Morris
2017-07-24 17:01 ` Eli Zaretskii [this message]
2017-07-24 17:29 ` Stefan Monnier
2017-07-24 18:04 ` Eli Zaretskii
2017-07-24 18:16 ` Stefan Monnier
2017-07-24 18:37 ` Eli Zaretskii
2017-07-24 20:05 ` Stefan Monnier
2017-07-24 18:20 ` Stefan Monnier
2017-07-24 18:43 ` Eli Zaretskii
2017-07-24 20:02 ` Stefan Monnier
2017-07-25 2:36 ` Eli Zaretskii
2017-07-25 3:22 ` Stefan Monnier
2017-07-25 5:18 ` Eli Zaretskii
2017-07-25 7:37 ` Michael Albinus
2017-07-25 13:56 ` Stefan Monnier
2017-07-26 16:54 ` Glenn Morris
2017-07-26 18:59 ` Eli Zaretskii
2017-07-24 17:26 ` Michael Albinus
2017-07-24 17:30 ` Stefan Monnier
2017-07-24 17:34 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r2x57orp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@IRO.UMontreal.CA \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).