From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Clarify `pcase' `rx' pattern doc Date: Fri, 20 Jul 2018 11:45:35 +0300 Message-ID: <83r2jy1ej4.fsf@gnu.org> References: <87fu1rqr6m.fsf@web.de> <87in6gff2t.fsf@web.de> <83wouwrq3d.fsf@gnu.org> <87tvpw4cjt.fsf@web.de> <83vaacqjpl.fsf@gnu.org> <87lgb841g0.fsf@web.de> <831scxvd5a.fsf@gnu.org> <87bmbk4586.fsf@web.de> <834lhbleol.fsf@gnu.org> <8736wvf9rv.fsf@web.de> <83va9ri1wh.fsf@gnu.org> <87wou7dsgb.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532076258 7588 195.159.176.226 (20 Jul 2018 08:44:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jul 2018 08:44:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 20 10:44:13 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgR1J-0001tx-I8 for ged-emacs-devel@m.gmane.org; Fri, 20 Jul 2018 10:44:13 +0200 Original-Received: from localhost ([::1]:46985 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgR3P-0004LZ-CV for ged-emacs-devel@m.gmane.org; Fri, 20 Jul 2018 04:46:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgR2i-0004LJ-HQ for emacs-devel@gnu.org; Fri, 20 Jul 2018 04:45:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgR2f-0000YC-4a for emacs-devel@gnu.org; Fri, 20 Jul 2018 04:45:40 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgR2e-0000Y6-Nr; Fri, 20 Jul 2018 04:45:36 -0400 Original-Received: from [176.228.60.248] (port=1141 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgR2e-0005yi-6r; Fri, 20 Jul 2018 04:45:36 -0400 In-reply-to: <87wou7dsgb.fsf@web.de> (message from Michael Heerdegen on Sat, 07 Jul 2018 16:35:32 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227572 Archived-At: > From: Michael Heerdegen > Cc: emacs-devel@gnu.org > Date: Sat, 07 Jul 2018 16:35:32 +0200 > > > If you fear that having this sentence in the doc string will somehow > > preclude us from making the code change, or make it harder, then the > > doc string already says that, so if there's a problem, it is already > > with us, no? > > No, my fear is that users or package maintainers rely on what we > document now although we surely know what we add to the docs won't hold > later. IOW, what you suggest to document is a misfeature we want to get > rid of very soon. I intend to do this right after this commit we speak > about here (but in master). The main effect would be a merge conflict. > > > > AFAIK, in `let' VAR must be a symbol, but it seems the submatch is also > > > numbered as side effect, e.g. > > > > > > (pcase "Hala" > > > ((rx "H" (let x "a") (regex ".*") (backref 1)) x)) > > > ==> "a" > > > > So you agree that "explicitly named" is a better wording? > > I think it would be an improvement, yes. OK, fixed as discussed and pushed to the emacs-26 branch. Thanks.