From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Tue, 30 Oct 2018 08:17:46 +0200 Message-ID: <83r2g8klf9.fsf@gnu.org> References: <83tvlcsnee.fsf@gnu.org> <86mur137n8.fsf@gmail.com> <20181029130132.GB4195@ACM> <20181029134722.GC4195@ACM> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1540880143 22706 195.159.176.226 (30 Oct 2018 06:15:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 06:15:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 30 07:15:38 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHNJQ-0005mq-Mj for ged-emacs-devel@m.gmane.org; Tue, 30 Oct 2018 07:15:36 +0100 Original-Received: from localhost ([::1]:51058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHNLX-0007cQ-40 for ged-emacs-devel@m.gmane.org; Tue, 30 Oct 2018 02:17:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHNLR-0007VO-IH for emacs-devel@gnu.org; Tue, 30 Oct 2018 02:17:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHNLN-0002Ye-Eg for emacs-devel@gnu.org; Tue, 30 Oct 2018 02:17:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHNLL-0002Qu-L4; Tue, 30 Oct 2018 02:17:36 -0400 Original-Received: from [176.228.60.248] (port=3018 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gHNLL-0002mN-7M; Tue, 30 Oct 2018 02:17:35 -0400 In-reply-to: (message from Stefan Monnier on Mon, 29 Oct 2018 17:08:38 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230801 Archived-At: > From: Stefan Monnier > Date: Mon, 29 Oct 2018 17:08:38 -0400 > > Thanks. What do you think of the patch below? Thanks for doing this. > I'd rather keep it defined in terms of its differences w.r.t `dolist`, > but if really needed, we could change the doc so it doesn't rely on > `dolist`s own doc at all. I think the doc string should be (more) independent, at least in the pcase-dolist case, because the semantics of executing BODY with PATTERN matched against a LIST element is significantly different from that of executing the dolist BODY with a VAR binding. And the description of that semantics is missing from the doc string you propose. > We do have to keep the reference to `pcase` because we don't want to > repeat the definition of what a pcase pattern can look like. I see no problem to say something like See `pcase' for the description of possible forms of PATTERN.