From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Tue, 30 Oct 2018 19:00:02 +0200 Message-ID: <83r2g7jrot.fsf@gnu.org> References: <83tvlcsnee.fsf@gnu.org> <86mur137n8.fsf@gmail.com> <20181029130132.GB4195@ACM> <20181029134722.GC4195@ACM> <83r2g8klf9.fsf@gnu.org> <83wopzk3sw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1540918685 30034 195.159.176.226 (30 Oct 2018 16:58:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 16:58:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 30 17:58:01 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHXL2-0007cY-Pt for ged-emacs-devel@m.gmane.org; Tue, 30 Oct 2018 17:57:56 +0100 Original-Received: from localhost ([::1]:54491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHXN9-0005xk-6x for ged-emacs-devel@m.gmane.org; Tue, 30 Oct 2018 13:00:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHXMw-0005uG-W5 for emacs-devel@gnu.org; Tue, 30 Oct 2018 12:59:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHXMt-0005mm-1H for emacs-devel@gnu.org; Tue, 30 Oct 2018 12:59:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHXMs-0005mJ-RC; Tue, 30 Oct 2018 12:59:50 -0400 Original-Received: from [176.228.60.248] (port=3616 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gHXMs-0005MZ-D6; Tue, 30 Oct 2018 12:59:50 -0400 In-reply-to: (message from Stefan Monnier on Tue, 30 Oct 2018 11:00:47 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230832 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Tue, 30 Oct 2018 11:00:47 -0400 > > >> (dolist (x LIST) (pcase-let ((PATTERN x)) BODY)) > > You aren't saying that showing the code removes the need for any > > documentation of what it does, do you? ;-) > > I think I am, yes. Seriously? This cannot fly: for starters, the user could be using an Emacs where *.el files are not accessible. More generally, it sounds like a defeat to say that we are unable to describe the behavior, and ask users to read the code instead. > In cases like these where the definition is really just a trivial > combination of two less trivial elements, it might be a better > option for the docstring, since it is both more concise and more > precise than whatever wording we can come up with to try and repeat > what dolist and pcase-let do. Tell you what: how about if you try explaining this, and I will then make a better doc string out of that? Deal?