From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Thu, 03 Jan 2019 16:09:26 +0200
Message-ID: <83r2dt3ka1.fsf@gnu.org>
References: <20190102212218.74902-1-phst@google.com>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1546524735 20745 195.159.176.226 (3 Jan 2019 14:12:15 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Thu, 3 Jan 2019 14:12:15 +0000 (UTC)
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 03 15:12:11 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gf3jG-0005IF-PH
	for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2019 15:12:10 +0100
Original-Received: from localhost ([127.0.0.1]:54146 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1gf3lN-0000jw-9m
	for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2019 09:14:21 -0500
Original-Received: from eggs.gnu.org ([208.118.235.92]:58758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1gf3gm-0004zZ-No
	for emacs-devel@gnu.org; Thu, 03 Jan 2019 09:09:37 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1gf3gm-0007wA-7C
	for emacs-devel@gnu.org; Thu, 03 Jan 2019 09:09:36 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41544)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1gf3gh-0007v4-G8; Thu, 03 Jan 2019 09:09:32 -0500
Original-Received: from [176.228.60.248] (port=4757 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1gf3gg-0001hk-Kt; Thu, 03 Jan 2019 09:09:31 -0500
In-reply-to: <20190102212218.74902-1-phst@google.com> (message from Philipp
	Stephani on Wed, 2 Jan 2019 22:22:18 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:232137
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/232137>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Wed,  2 Jan 2019 22:22:18 +0100
> Cc: Philipp Stephani <phst@google.com>

One comment about the new module test:

> +      struct timespec now;
> +      if (clock_gettime (CLOCK_REALTIME, &now))

clock_gettime is not portable enough; please use gettime (from Gnulib;
see lib/gettime.c), it will call clock_gettime where it's available.

Thanks.