From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: tabulated-list sort icon is reversed Date: Fri, 08 Mar 2019 11:43:42 +0200 Message-ID: <83r2bhaegh.fsf@gnu.org> References: <87d0v1lsns.fsf@fastmail.fm> <532F6D74-E21C-45A2-B85B-01133DE1E8A1@scratch.space> <6e662c5b-3d04-2157-6712-aadcb6077f2b@gmail.com> <83a7j0pzbh.fsf@gnu.org> <83sgwpm92r.fsf@gnu.org> <83imx1h4rm.fsf@gnu.org> <83tvglf8h0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="205183"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Philippe Vaucher Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 08 10:44:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2C34-000rFu-FR for ged-emacs-devel@m.gmane.org; Fri, 08 Mar 2019 10:44:14 +0100 Original-Received: from localhost ([127.0.0.1]:39859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2C33-00013k-3R for ged-emacs-devel@m.gmane.org; Fri, 08 Mar 2019 04:44:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2C2t-00012H-1v for emacs-devel@gnu.org; Fri, 08 Mar 2019 04:44:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2C2r-0003Dh-K3; Fri, 08 Mar 2019 04:44:01 -0500 Original-Received: from [176.228.60.248] (port=2835 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h2C2q-0000ex-Lc; Fri, 08 Mar 2019 04:44:01 -0500 In-reply-to: (message from Philippe Vaucher on Sat, 2 Mar 2019 20:06:49 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233926 Archived-At: > From: Philippe Vaucher > Date: Sat, 2 Mar 2019 20:06:49 +0100 > Cc: Stefan Monnier , Emacs developers > > Here we go. I'm not familiar with the NEWS redaction so feel free to change the text. Thanks. See some minor comments below. Also, what about updating the Emacs user manual with the description of the new user options? > (tabulated-list-gui-sort-indicator-asc): New defcustom. > (tabulated-list-gui-sort-indicator-desc): New defcustom. > (tabulated-list-tty-sort-indicator-asc): New defcustom. > (tabulated-list-tty-sort-indicator-desc): New defcustom. This is not wrong, but could be abbreviated: (tabulated-list-gui-sort-indicator-asc) (tabulated-list-gui-sort-indicator-desc) (tabulated-list-tty-sort-indicator-asc) (tabulated-list-tty-sort-indicator-desc): New defcustom. > (tabulated-list-glyphless-char-display): Removal. We use "Removed". > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -279,6 +279,15 @@ matches strings where the pattern appears as a subsequence. Put > simply, makes "foo" complete to both "barfoo" and "frodo". Add 'flex' > to 'completion-styles' or 'completion-category-overrides' to use it. > > ++++ the "+++" marker means the manuals have been updated, but I don't see the patch for the manuals. > +** New user options for tabulated list sort indicators The header should end in a period. > +The user can customize which sorting indicator character to display > +near the current column in Tabulated Lists: > +- tabulated-list-gui-sort-indicator-asc > +- tabulated-list-gui-sort-indicator-desc > +- tabulated-list-tty-sort-indicator-asc > +- tabulated-list-tty-sort-indicator-desc We don't use itemized lists in NEWS, and also we quote Lisp symbols 'like this'. > +(defcustom tabulated-list-gui-sort-indicator-asc ?▼ > + "GUI indicator displayed near the current column when the sort order > +is ascending." the first line of a doc string should be a single complete sentence, fr the benefit of the apropos* commands, which only show the first line. If the first sentence is too long, say the most important part in the first sentence, and leave the details for the rest of the doc string. In this case, I'd suggest something like this: "Indicator for column sorted in ascending order, for GUI frames. See `tabulated-list-tty-sort-indicator-asc' for indicator used on text-mode frames." > -(defvar tabulated-list-glyphless-char-display > +(defun tabulated-list-make-glyphless-char-display-table () > + "Make the `glyphless-char-display' table used in Tabulated List buffers." I'd suggest to mention here that this table is used for displaying the soring indicators.