From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Increase minimum required GTK versions? Date: Fri, 12 Apr 2019 21:49:54 +0300 Message-ID: <83r2a7kqi6.fsf@gnu.org> References: <87h8b9tz84.fsf@gmail.com> <83h8b98wg3.fsf@gnu.org> <87d0lxty7f.fsf@gmail.com> <537036b7-549c-0aab-cc06-70c26c683ac7@cs.ucla.edu> <87y34kiloy.fsf@gmail.com> <87o95f141i.fsf@gmail.com> <838swj6nuk.fsf@gnu.org> <87h8b61rid.fsf@gmail.com> <83sgup6ef8.fsf@gnu.org> <87tvf5tm4f.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="138928"; mail-complaints-to="usenet@blaine.gmane.org" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 12 20:51:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hF1HA-000a3w-L5 for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 20:51:48 +0200 Original-Received: from localhost ([127.0.0.1]:41335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1H9-0001Kj-F3 for ged-emacs-devel@m.gmane.org; Fri, 12 Apr 2019 14:51:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1Fe-0008Oa-4W for emacs-devel@gnu.org; Fri, 12 Apr 2019 14:50:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF1Fb-0005l8-U7; Fri, 12 Apr 2019 14:50:13 -0400 Original-Received: from [176.228.60.248] (port=1680 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hF1FZ-00086w-8q; Fri, 12 Apr 2019 14:50:11 -0400 In-reply-to: <87tvf5tm4f.fsf@gmail.com> (message from Alex on Wed, 10 Apr 2019 18:35:12 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235361 Archived-At: > From: Alex > Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org > Date: Wed, 10 Apr 2019 18:35:12 -0600 > > >> * Old file selection dialog > >> This is only optionally used in GTK 2, but the old dialog is long > >> deprecated in GTK 2 (removed in GTK 3), so I figured that this is a good > >> time to remove it and simplify the existing code. > > > > I think this should be left alone. It's a separate issue anyway, and > > should be submitted separately. It would be good to try to establish > > whether this feature is turned on by someone, but given that it's only > > for GTK2, I tend to think we should simply let it die a natural death > > together with GTK2. > > Okay, done. Are you sure? I still see the code related to this being removed. > I've attached an updated patch. Fine with me, modulo the file dialog stuff. Thanks.