From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Sun, 28 Apr 2019 21:42:01 +0300
Message-ID: <83r29mt1ja.fsf@gnu.org>
References: <83y36nl7rl.fsf@gnu.org> <20190211201739.25229-1-phst@google.com>
	<834l97pv0l.fsf@gnu.org>
	<CAArVCkQsvEuPyFmuVSaopok5AWJXd7mAhCN_gVk-PKr5VHaokw@mail.gmail.com>
	<CAArVCkQ8v7jKOkrX8mWWTQYOMmcmsAVzANZifvkbormNCxrtWQ@mail.gmail.com>
	<83y345bvk6.fsf@gnu.org>
	<CAArVCkRapQS6jBn+2671WPGMi6qYeQPKWypPgxA7Ea7UC27QAQ@mail.gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="175791"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: phst@google.com, emacs-devel@gnu.org
To: Philipp Stephani <p.stephani2@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 28 20:44:21 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hKomj-000jaN-3z
	for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 20:44:21 +0200
Original-Received: from localhost ([127.0.0.1]:47326 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hKomi-00031k-0F
	for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 14:44:20 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:48435)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hKoli-0002zc-Jx
	for emacs-devel@gnu.org; Sun, 28 Apr 2019 14:43:19 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39117)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hKokv-00082i-Cm; Sun, 28 Apr 2019 14:42:30 -0400
Original-Received: from [176.228.60.248] (port=1354 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hKokr-0005Dq-8N; Sun, 28 Apr 2019 14:42:29 -0400
In-reply-to: <CAArVCkRapQS6jBn+2671WPGMi6qYeQPKWypPgxA7Ea7UC27QAQ@mail.gmail.com>
	(message from Philipp Stephani on Sun, 28 Apr 2019 20:19:42 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236012
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236012>

> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 28 Apr 2019 20:19:42 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>, Philipp Stephani <phst@google.com>
> 
> > > Question: Would it be OK to backport the first part (using QUITP in
> > > module_should_quit) to Emacs 26.3?
> >
> > Please show the part that you suggest to backport, I don't think I
> > understand what that is.
> 
> The initial patch, i.e.
> 
> --- a/src/emacs-module.c
> +++ b/src/emacs-module.c
> @@ -671,13 +671,13 @@ module_vec_size (emacs_env *env, emacs_value vec)
>    return ASIZE (lvec);
>  }
> 
> -/* This function should return true if and only if maybe_quit would do
> -   anything.  */
> +/* This function should return true if and only if maybe_quit would
> +   quit.  */
>  static bool
>  module_should_quit (emacs_env *env)
>  {
>    MODULE_FUNCTION_BEGIN_NO_CATCH (false);
> -  return (! NILP (Vquit_flag) && NILP (Vinhibit_quit)) || pending_signals;
> +  return QUITP;
>  }

If you don't mind breaking compatibility in a minor release, I'm okay
with backporting this.