From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Add support for base64url variant
Date: Thu, 23 May 2019 21:50:50 +0300
Message-ID: <83r28p57jp.fsf@gnu.org>
References: <87pnobiglo.fsf@killashandra.ballybran.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="184274"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Pierre =?iso-8859-1?Q?T=E9choueyres?= <pierre.techoueyres@free.fr>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 23 20:51:34 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hTsoQ-000lpQ-B7
	for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 20:51:34 +0200
Original-Received: from localhost ([127.0.0.1]:41952 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hTsoP-0006WT-Be
	for ged-emacs-devel@m.gmane.org; Thu, 23 May 2019 14:51:33 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:43755)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hTsnk-0006WC-4d
	for emacs-devel@gnu.org; Thu, 23 May 2019 14:50:53 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38881)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hTsnc-0003OU-Hr; Thu, 23 May 2019 14:50:49 -0400
Original-Received: from [176.228.60.248] (port=3919 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hTsnY-0000Wz-DA; Thu, 23 May 2019 14:50:41 -0400
In-reply-to: <87pnobiglo.fsf@killashandra.ballybran.fr> (message from Pierre
	=?iso-8859-1?Q?T=E9choueyres?= on Wed, 22 May 2019 00:32:19 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236943
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236943>

> From: Pierre Téchoueyres <pierre.techoueyres@free.fr>
> Date: Wed, 22 May 2019 00:32:19 +0200
> 
> +				    NILP(no_pad), !NILP(url_variant),

Please leave one blank between the name of a macro or function and the
following opening parenthesis.

> +	  if (pad) {
> +	    *e++ = '=';
> +	    *e++ = '=';
> +	  }

This is not our style of writing blocks in braces.  We use this style:

   if (pad)
     {
       *e++ = '=';
       ...

> +	  *e++ = b64_value_to_char[value];
> +	  if (pad) {
> +	    *e++ = '=';
> +	  }

Likewise.

I'd suggest to call the new argument base64url or somesuch, since
this is trhe official name.