Re: Making TTY menus more visual

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

From: Eli Zaretskii <eliz@gnu.org>
To: Jared Finder <jared@finder.org>
Cc: emacs-devel@gnu.org
Subject: Re: Making TTY menus more visual
Date: Fri, 02 Oct 2020 10:31:33 +0300	[thread overview]
Message-ID: <83r1qhf5ii.fsf@gnu.org> (raw)
In-Reply-To: <087df85a965fac6555a755c1bbebf1ea@finder.org> (emacs-devel@gnu.org)

> Date: Thu, 01 Oct 2020 23:16:49 -0700
> From: Jared Finder via "Emacs development discussions." <emacs-devel@gnu.org>
> 
> Right now in Emacs on a TTY, clicking on the menu bar with the mouse pops up menu navigation through
> tmm.el.  I think it would make more sense for mouse clicks to pop up visual menus via
> menu-bar-open-mouse by default.

Which mouse support do you have on that TTY?  Is it GPM or is it
something else?

If Emacs opens tmm-menubar when you click on the menu bar, it means
Emacs doesn't understand that a mouse click on the menu bar was
received.  Can you tell why this happens in your case?

> But I get why that's not the current default. These visual menus currently behave very poorly with a mouse
> on a Linux TTY: Clicking <mouse-1> anywhere selects the currently selected item, not the item you clicked
> on.

What do you mean by "currently selected item"?

> I have a prototype fix for this that I've been working on. If you think it makes sense, I can finish it up. I've
> attached the changes in case you want to take a look.

I don't understand why you need all this.  TTY menus work perfectly on
MS-Windows console: the place where you click on the menu bar
determines the menu that is dropped down.  For example, if you click
on Options, you get the Options menu.

It is supposed to work the same on Linux terminals with a mouse: when
you click the mouse on the menu bar, the function x_popup_menu_1 is
supposed to be called with the argument POSITION that specifies the
coordinates of the click, and then tty_menu_show, called by
x_popup_menu_1, uses those coordinates to decide which menu to drop
down.  Which of these doesn't work for you, and why?

next prev parent reply other threads:[~2020-10-02 7:31 UTC|newest]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r1qhf5ii.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jared@finder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).