From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: ai_flags in calls to getaddrinfo, broader call for reproducibility check Date: Tue, 12 Jan 2021 17:01:53 +0200 Message-ID: <83r1mqdwri.fsf@gnu.org> References: <83sg7mggls.fsf@gnu.org> <83czymc8nq.fsf@gnu.org> <74b7a0a9-0eb3-7944-19d2-f72424ee72d7@dasyatidae.com> <83eeirfqbo.fsf@gnu.org> <87o8hvscfi.fsf@gmail.com> <8335z7fmnz.fsf@gnu.org> <87ft374axc.fsf@gmail.com> <83wnwjdwww.fsf@gnu.org> <87czyb2nvq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rtt@dasyatidae.com, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 12 16:03:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzLCI-00093b-SW for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Jan 2021 16:03:02 +0100 Original-Received: from localhost ([::1]:47464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzLCH-0006al-T3 for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Jan 2021 10:03:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzLAy-0005Od-CI for emacs-devel@gnu.org; Tue, 12 Jan 2021 10:01:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60901) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzLAx-0006aE-T9; Tue, 12 Jan 2021 10:01:40 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1751 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kzLAw-0007A7-A3; Tue, 12 Jan 2021 10:01:39 -0500 In-Reply-To: <87czyb2nvq.fsf@gmail.com> (message from Robert Pluim on Mon, 11 Jan 2021 21:56:57 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262979 Archived-At: > From: Robert Pluim > Cc: rtt@dasyatidae.com, emacs-devel@gnu.org > Date: Mon, 11 Jan 2021 21:56:57 +0100 > > > Tell me what to try, and I will show the results. TIA. > > Iʼve lost track of which tests were failing, but something like > following. And if the 'dns-query' calls succeed but the > network-lookup-address-info ones fail then we have a really messed up > situation. You assume that a TCP connection to the DNS server there will succeed? It doesn't, at least judging by the error message (dns.el has no debug facilities, so it's hard to know better). So I think I will now stop wasting your time, and just give up on having these tests avoid false negatives. But before I go! I guess at least one of the 2 offending tests, i.e. this one: (ert-deftest lookup-family-specification () "`network-lookup-address-info' should only accept valid family symbols." (skip-unless (not (getenv "EMACS_HYDRA_CI"))) (with-timeout (60 (ert-fail "Test timed out")) (should-error (network-lookup-address-info "google.com" 'both)) (should (network-lookup-address-info "google.com" 'ipv4)) (when (featurep 'make-network-process '(:family ipv6)) (should (network-lookup-address-info "google.com" 'ipv6))))) could use "localhost" instead of google.com, since it only tests the input validity?